Attachment 360049 Details for Bug 193798 – Fixes the bug

[patch] Fixes the bug

bug-193798-20190124164513.patch (text/plain), 2.44 KB, created by Ryosuke Niwa on 2019-01-24 16:45:14 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2019-01-24 16:45:14 PST

Size: 2.44 KB

patch

obsolete

>Subversion Revision: 240366
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 53407f49cf056d12d22db83d192ae7c054d5218e..4402f2263ed20c369acf2637ee88a5c1c3e34f7b 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-01-24  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        iOS: Split keyboard should not shrink visualViewport.height
>+        https://bugs.webkit.org/show_bug.cgi?id=193798
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Treat a split keyboard like a floating keyboard and don't consider its input view bounds in computing the visible content rects.
>+
>+        No new tests since while it's possible to transition between split and merged keyboard using some SPI,
>+        there isn't a reliable mechanism to reset the keyboard state. e.g. we need to wait for a hard-coded amount of time.
>+
>+        * Platform/spi/ios/UIKitSPI.h:
>+        * UIProcess/API/Cocoa/WKWebView.mm:
>+        (-[WKWebView _keyboardChangedWithInfo:adjustScrollView:]):
>+
> 2019-01-23  Alex Christensen  <achristensen@webkit.org>
> 
>         Stop using NetworkProcess::singleton
>diff --git a/Source/WebKit/Platform/spi/ios/UIKitSPI.h b/Source/WebKit/Platform/spi/ios/UIKitSPI.h
>index b5c3e34c21cc09dc0cd3ea8c4d7aff2e58fb45db..d4479068b853b938ebbd300ccb223b0bea36e9fc 100644
>--- a/Source/WebKit/Platform/spi/ios/UIKitSPI.h
>+++ b/Source/WebKit/Platform/spi/ios/UIKitSPI.h
>@@ -297,6 +297,7 @@ typedef enum {
> + (UIPeripheralHost *)activeInstance;
> + (CGRect)visiblePeripheralFrame;
> - (BOOL)isOnScreen;
>+- (BOOL)isUndocked;
> - (UIKeyboardRotationState *)rotationState;
> @end
> 
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>index 5f754aa55f86d401cd76bee65cd954ddd761f876..2a1bb5373a90be318a38cb5a3e28b10ad5915aa1 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>@@ -3175,6 +3175,9 @@ - (void)_keyboardChangedWithInfo:(NSDictionary *)keyboardInfo adjustScrollView:(
>     else
>         _inputViewBounds = [self.window convertRect:CGRectIntersection([endFrameValue CGRectValue], self.window.screen.bounds) fromWindow:nil];
> 
>+    if ([[UIPeripheralHost sharedInstance] isUndocked])
>+        _inputViewBounds = CGRectZero;
>+
>     if (adjustScrollView) {
>         CGFloat bottomInsetBeforeAdjustment = [_scrollView contentInset].bottom;
>         SetForScope<BOOL> insetAdjustmentGuard(_currentlyAdjustingScrollViewInsetsForKeyboard, YES);

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193798: 360049 | 360060