Attachment 360030 Details for Bug 193776 – patch for landing

[patch] patch for landing

a-backup.diff (text/plain), 1.69 KB, created by Saam Barati on 2019-01-24 13:30:17 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2019-01-24 13:30:17 PST

Size: 1.69 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 240446)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-01-24  Saam Barati  <sbarati@apple.com>
>+
>+        Update ARM64EHash
>+        https://bugs.webkit.org/show_bug.cgi?id=193776
>+        <rdar://problem/47526457>
>+
>+        Reviewed by Mark Lam.
>+
>+        See radar for details.
>+
>+        * assembler/AssemblerBuffer.h:
>+        (JSC::ARM64EHash::update):
>+        (JSC::ARM64EHash::finalHash const):
>+
> 2019-01-24  Guillaume Emont  <guijemont@igalia.com>
> 
>         [JSC] Reenable baseline JIT on mips
>Index: Source/JavaScriptCore/assembler/AssemblerBuffer.h
>===================================================================
>--- Source/JavaScriptCore/assembler/AssemblerBuffer.h	(revision 240446)
>+++ Source/JavaScriptCore/assembler/AssemblerBuffer.h	(working copy)
>@@ -155,14 +155,14 @@ namespace JSC {
>             uint64_t input = value ^ m_hash;
>             uint64_t a = static_cast<uint32_t>(tagInt(input, static_cast<PtrTag>(0)) >> 39);
>             uint64_t b = tagInt(input, static_cast<PtrTag>(0xb7e151628aed2a6a)) >> 23;
>-            m_hash = a | b;
>+            m_hash = a ^ b;
>         }
>         uint32_t finalHash() const
>         {
>             uint64_t hash = m_hash;
>             uint64_t a = static_cast<uint32_t>(tagInt(hash, static_cast<PtrTag>(0xbf7158809cf4f3c7)) >> 39);
>             uint64_t b = tagInt(hash, static_cast<PtrTag>(0x62e7160f38b4da56)) >> 23;
>-            return static_cast<uint32_t>(a | b);
>+            return static_cast<uint32_t>(a ^ b);
>         }
>     private:
>         uint32_t m_hash { 0 };

Actions: View | Formatted Diff | Diff

Attachments on bug 193776: 360030