WebKit Bugzilla
Attachment 360022 Details for
Bug 193741
: DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193741-20190124105552.patch (text/plain), 1.93 KB, created by
zalan
on 2019-01-24 10:55:56 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
zalan
Created:
2019-01-24 10:55:56 PST
Size:
1.93 KB
patch
obsolete
>Subversion Revision: 239927 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 2870e6b8095f05a11adae1efb068f71a2f7dea95..20c4f9b4acbe50438e776e08d01eb4cf9c3cb64d 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,23 @@ >+2019-01-23 Zalan Bujtas <zalan@apple.com> >+ >+ DidFirstVisuallyNonEmptyLayout milestone should always fire at some point. >+ https://bugs.webkit.org/show_bug.cgi?id=193741 >+ <rdar://problem/47135030> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ fireLayoutRelatedMilestonesIfNeeded() is part of the post-layout tasks. In certain cases when >+ 1. the received data is not "contentful" yet >+ 2. and we are expecting some more (loading is not complete yet) >+ 3. but no layout is initiated anymore >+ nothing triggers the milestone firing. >+ >+ This patch ensures that we fire the DidFirstVisuallyNonEmptyLayout when the frame load is complete unless we already did. >+ >+ * page/FrameView.cpp: >+ (WebCore::FrameView::FrameView): >+ (WebCore::FrameView::loadProgressingStatusChanged): >+ > 2019-01-14 Zan Dobersek <zdobersek@igalia.com> > > DOMCacheStorage: use-after-move in doSequentialMatch() >diff --git a/Source/WebCore/page/FrameView.cpp b/Source/WebCore/page/FrameView.cpp >index d25a7e61a7ae34cb257e14f0e525c73982282de9..7e51221b8543f35b6cbf8aa4729d944a9a972e47 100644 >--- a/Source/WebCore/page/FrameView.cpp >+++ b/Source/WebCore/page/FrameView.cpp >@@ -2841,6 +2841,9 @@ void FrameView::disableLayerFlushThrottlingTemporarilyForInteraction() > > void FrameView::loadProgressingStatusChanged() > { >+ auto hasPendingVisuallyNonEmptyCallback = m_firstVisuallyNonEmptyLayoutCallbackPending && !m_isVisuallyNonEmpty; >+ if (hasPendingVisuallyNonEmptyCallback && frame().loader().isComplete()) >+ fireLayoutRelatedMilestonesIfNeeded(); > updateLayerFlushThrottling(); > adjustTiledBackingCoverage(); > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193741
:
359960
|
359983
|
360014
|
360020
|
360022
|
360034
|
360039