Attachment 360016 Details for Bug 193770 – Patch

[patch] Patch

bug-193770-20190124092040.patch (text/plain), 1.92 KB, created by Chris Dumez on 2019-01-24 09:20:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-01-24 09:20:40 PST

Size: 1.92 KB

patch

obsolete

>Subversion Revision: 240435
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 7c7a865973ba6ddcd535f8627e1f88c0fca89393..152742bce6be62246a8d4afdd2d7ba03e1997d53 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-24  Chris Dumez  <cdumez@apple.com>
>+
>+        [ Mojave Release ] ProcessSwap.PageShowHide is a flakey API crash
>+        https://bugs.webkit.org/show_bug.cgi?id=193770
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make sure we received all the messages before we validate them.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
>+
> 2019-01-24  Philippe Normand  <pnormand@igalia.com>
> 
>         [WPE] Remove hard dependency on subprocess32 for the API tests
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>index fda46a597c8d3c03e3d04834dc31ea6250a2e230..a8119534788740344332e760718cc8498fb1927e 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>@@ -2340,6 +2340,9 @@ TEST(ProcessSwap, PageShowHide)
>     TestWebKitAPI::Util::run(&done);
>     done = false;
> 
>+    while ([receivedMessages count] < 7)
>+        TestWebKitAPI::Util::sleep(0.1);
>+
>     EXPECT_EQ(7u, [receivedMessages count]);
>     EXPECT_WK_STREQ(@"pson://www.webkit.org/main.html - pageshow NOT persisted", receivedMessages.get()[0]);
>     if ([receivedMessages.get()[1] hasPrefix:@"pson://www.webkit.org/main.html"]) {
>@@ -2430,6 +2433,9 @@ TEST(ProcessSwap, LoadUnload)
>     TestWebKitAPI::Util::run(&done);
>     done = false;
> 
>+    while ([receivedMessages count] < 7)
>+        TestWebKitAPI::Util::sleep(0.1);
>+
>     EXPECT_EQ(7u, [receivedMessages count]);
>     EXPECT_WK_STREQ(@"pson://www.webkit.org/main.html - load", receivedMessages.get()[0]);
>     if ([receivedMessages.get()[1] hasPrefix:@"pson://www.webkit.org/main.html"]) {

Actions: View | Formatted Diff | Diff

Attachments on bug 193770: 360016