Attachment 360015 Details for Bug 193771 – Patch

[patch] Patch

bug-193771-20190124091056.patch (text/plain), 1.38 KB, created by Jonathan Bedard on 2019-01-24 09:10:57 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-01-24 09:10:57 PST

Size: 1.38 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240435)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-01-24  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: Missing PID in crashlog name should not be fatal
>+        https://bugs.webkit.org/show_bug.cgi?id=193771
>+
>+        If we can't determine the PID of a crashlog, just ignore the crashlog instead
>+        of raising an exception.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/port/darwin.py:
>+        (DarwinPort._merge_crash_logs):
>+
> 2019-01-24  Philippe Normand  <pnormand@igalia.com>
> 
>         [WPE] Remove hard dependency on subprocess32 for the API tests
>Index: Tools/Scripts/webkitpy/port/darwin.py
>===================================================================
>--- Tools/Scripts/webkitpy/port/darwin.py	(revision 240435)
>+++ Tools/Scripts/webkitpy/port/darwin.py	(working copy)
>@@ -104,7 +104,7 @@ class DarwinPort(ApplePort):
>                 else:
>                     process_name = test.split('-')[0]
>                     pid = int(test.split('-')[1])
>-            except IndexError:
>+            except IndexError, ValueError:
>                 continue
>             if not any(entry[1] == process_name and entry[2] == pid for entry in crashed_processes):
>                 # if this is a new crash, then append the logs

Actions: View | Formatted Diff | Diff

Attachments on bug 193771: 360015