WebKit Bugzilla
Attachment 359971 Details for
Bug 193747
: Refactor ServiceWorkerJob management by ServiceWorkerContainer to make it more memory safe
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193747-20190123163105.patch (text/plain), 1.58 KB, created by
youenn fablet
on 2019-01-23 16:31:06 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
youenn fablet
Created:
2019-01-23 16:31:06 PST
Size:
1.58 KB
patch
obsolete
>Subversion Revision: 240159 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 4e382bd0cf07dd25041ad7f00ae1405be82d4e71..47c4bd6da16d5b3cf05b5f36061fbfc38b9cf1e6 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,18 @@ >+2019-01-23 Youenn Fablet <youenn@apple.com> >+ >+ ServiceWorkerJob should notify its client in case its job is cancelled >+ https://bugs.webkit.org/show_bug.cgi?id=193747 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ When cancelling a script load, the load client is not notified. >+ Notify explicitly the job client to do the necessary cleanup. >+ >+ Covered by existing tests. >+ >+ * workers/service/ServiceWorkerJob.cpp: >+ (WebCore::ServiceWorkerJob::cancelPendingLoad): >+ > 2019-01-18 Youenn Fablet <youenn@apple.com> > > getUserMedia with a deviceId exact constraint with an empty string value should succeed >diff --git a/Source/WebCore/workers/service/ServiceWorkerJob.cpp b/Source/WebCore/workers/service/ServiceWorkerJob.cpp >index 71d1e5281c73556da5ef897b0a46896b14544a90..90bb3a8e3dbf5fa09be2eec102fe1ce061331965 100644 >--- a/Source/WebCore/workers/service/ServiceWorkerJob.cpp >+++ b/Source/WebCore/workers/service/ServiceWorkerJob.cpp >@@ -162,6 +162,7 @@ void ServiceWorkerJob::cancelPendingLoad() > return; > m_scriptLoader->cancel(); > m_scriptLoader = nullptr; >+ m_client->jobFailedLoadingScript(*this, ResourceError { errorDomainWebKitInternal, 0, m_jobData.scriptURL, "Load cancelled", ResourceError::Type::Cancellation }, WTF::nullopt); > } > > } // namespace WebCore
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193747
:
359971
|
360146
|
360180
|
360360
|
360602