WebKit Bugzilla
Attachment 359958 Details for
Bug 193742
: <rdar://problem/27686430> Revert workaround AVPlayer.setMuted bug on macOS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193742-20190123152939.patch (text/plain), 1.60 KB, created by
Benjamin Poulain
on 2019-01-23 15:29:40 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Benjamin Poulain
Created:
2019-01-23 15:29:40 PST
Size:
1.60 KB
patch
obsolete
>Subversion Revision: 240362 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 31aadd832dcae95fcbcbfea27fe4a7c474c2d45b..cb5856a999c08f7d79a9dd8b3e1a862fcf5522b9 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,13 @@ >+2019-01-23 Benjamin Poulain <benjamin@webkit.org> >+ >+ <rdar://problem/27686430> Revert workaround AVPlayer.setMuted bug on macOS >+ https://bugs.webkit.org/show_bug.cgi?id=193742 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: >+ The original bug was fixed, see radar: rdar://problem/27686430 >+ > 2019-01-23 Sihui Liu <sihui_liu@apple.com> > > Clean up IndexedDB files between tests >diff --git a/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h b/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h >index a2424dd80da2c43d767f3ade416cb7400bc54a57..e1b12dc5dff9d39194aaaf18ca12e9912fa00f9e 100644 >--- a/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h >+++ b/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h >@@ -170,9 +170,7 @@ private: > bool platformPaused() const override; > MediaTime currentMediaTime() const override; > void setVolume(float) override; >-#if PLATFORM(IOS_FAMILY) > bool supportsMuting() const override { return true; } >-#endif > void setMuted(bool) override; > void setClosedCaptionsVisible(bool) override; > void paint(GraphicsContext&, const FloatRect&) override;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193742
: 359958