Attachment 359908 Details for Bug 193695 – Proposed patch

[patch] Proposed patch

0001-ews-app-Rename-ews-model-Builds-to-Build.patch (text/plain), 3.33 KB, created by Aakash Jain on 2019-01-23 11:18:01 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-23 11:18:01 PST

Size: 3.33 KB

patch

obsolete

>From 1094858e6163ff6e84d546885ec347222c8a9d63 Mon Sep 17 00:00:00 2001
>From: Aakash Jain <aakash_jain@apple.com>
>Date: Wed, 23 Jan 2019 13:31:33 -0500
>Subject: [PATCH 1/3] [ews-app] Rename ews model Builds to Build
> https://bugs.webkit.org/show_bug.cgi?id=193695
>
>Reviewed by NOBODY (OOPS!).
>
>* BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
>(Build): Renamed Builds to Build.
>---
> Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py |  2 +-
> .../ews-app/ews/models/{builds.py => build.py}         |  2 +-
> Tools/BuildSlaveSupport/ews-app/ews/models/steps.py    |  4 ++--
> Tools/ChangeLog                                        | 10 ++++++++++
> 4 files changed, 14 insertions(+), 4 deletions(-)
> rename Tools/BuildSlaveSupport/ews-app/ews/models/{builds.py => build.py} (98%)
>
>diff --git a/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py b/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py
>index 27b41dd942a..486484d755c 100644
>--- a/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py
>+++ b/Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py
>@@ -1,4 +1,4 @@
> from buildermappings import *
>-from builds import *
>+from build import *
> from patch import *
> from steps import *
>diff --git a/Tools/BuildSlaveSupport/ews-app/ews/models/builds.py b/Tools/BuildSlaveSupport/ews-app/ews/models/build.py
>similarity index 98%
>rename from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py
>rename to Tools/BuildSlaveSupport/ews-app/ews/models/build.py
>index de18f2c6877..46b4b278c30 100644
>--- a/Tools/BuildSlaveSupport/ews-app/ews/models/builds.py
>+++ b/Tools/BuildSlaveSupport/ews-app/ews/models/build.py
>@@ -26,7 +26,7 @@ from django.db import models
> from ews.models.patch import Patch
> 
> 
>-class Builds(models.Model):
>+class Build(models.Model):
>     patch = models.ForeignKey(Patch, on_delete=models.CASCADE)
>     buildid = models.IntegerField(primary_key=True)
>     builderid = models.IntegerField()
>diff --git a/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py b/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py
>index dae8f536247..821b29582bb 100644
>--- a/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py
>+++ b/Tools/BuildSlaveSupport/ews-app/ews/models/steps.py
>@@ -23,12 +23,12 @@
> from __future__ import unicode_literals
> 
> from django.db import models
>-from ews.models.builds import Builds
>+from ews.models.build import Build
> 
> 
> class Steps(models.Model):
>     stepid = models.IntegerField(primary_key=True)
>-    build = models.ForeignKey(Builds, on_delete=models.CASCADE)
>+    build = models.ForeignKey(Build, on_delete=models.CASCADE)
>     result = models.IntegerField()
>     state_string = models.TextField()
>     started_at = models.IntegerField()
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 0dcfede603f..425672a74f6 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-22  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-app] Rename ews model Builds to Build
>+        https://bugs.webkit.org/show_bug.cgi?id=193695
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
>+        (Build): Renamed Builds to Build.
>+
> 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
> 
>         [build.webkit.org] Unit-test failure after r237113
>-- 
>2.17.2 (Apple Git-113)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193695: 359812 | 359908