Attachment 359907 Details for Bug 193729 – Proposed patch

[patch] Proposed patch

ews-app-rename-buildermappings.patch (text/plain), 5.64 KB, created by Aakash Jain on 2019-01-23 11:16:54 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-23 11:16:54 PST

Size: 5.64 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240348)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-23  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-app] Rename ews model buildermappings to buildermapping
>+        https://bugs.webkit.org/show_bug.cgi?id=193729
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
>+        (BuilderMapping): Renamed BuilderMappings to BuilderMapping.
>+        * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
>+
> 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
> 
>         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
>Index: Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py	(revision 240347)
>+++ Tools/BuildSlaveSupport/ews-app/ews/models/__init__.py	(working copy)
>@@ -1,4 +1,4 @@
>-from buildermappings import *
>+from buildermapping import *
> from builds import *
> from patch import *
> from steps import *
>Index: Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py	(revision 240347)	(from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py:240347)
>+++ Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py	(working copy)
>@@ -0,0 +1,33 @@
>+# Copyright (C) 2018 Apple Inc. All rights reserved.
>+#
>+# Redistribution and use in source and binary forms, with or without
>+# modification, are permitted provided that the following conditions
>+# are met:
>+# 1.  Redistributions of source code must retain the above copyright
>+#     notice, this list of conditions and the following disclaimer.
>+# 2.  Redistributions in binary form must reproduce the above copyright
>+#     notice, this list of conditions and the following disclaimer in the
>+#     documentation and/or other materials provided with the distribution.
>+#
>+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
>+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
>+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
>+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
>+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
>+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
>+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
>+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+
>+from __future__ import unicode_literals
>+
>+from django.db import models
>+
>+
>+class BuilderMappings(models.Model):
>+    builderid = models.IntegerField(primary_key=True)
>+    name = models.TextField()
>+
>+    def __str__(self):
>+        return "{}: {}".format(self.builderid, self.name)
>Index: Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py	(revision 240347)
>+++ Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py	(working copy)
>@@ -25,7 +25,7 @@ from __future__ import unicode_literals
> from django.db import models
> 
> 
>-class BuilderMappings(models.Model):
>+class BuilderMapping(models.Model):
>     builderid = models.IntegerField(primary_key=True)
>     name = models.TextField()
> 
>Index: Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py	(revision 240347)
>+++ Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py	(nonexistent)
>@@ -1,33 +0,0 @@
>-# Copyright (C) 2018 Apple Inc. All rights reserved.
>-#
>-# Redistribution and use in source and binary forms, with or without
>-# modification, are permitted provided that the following conditions
>-# are met:
>-# 1.  Redistributions of source code must retain the above copyright
>-#     notice, this list of conditions and the following disclaimer.
>-# 2.  Redistributions in binary form must reproduce the above copyright
>-#     notice, this list of conditions and the following disclaimer in the
>-#     documentation and/or other materials provided with the distribution.
>-#
>-# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
>-# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
>-# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>-# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
>-# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
>-# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
>-# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
>-# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
>-# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>-
>-from __future__ import unicode_literals
>-
>-from django.db import models
>-
>-
>-class BuilderMappings(models.Model):
>-    builderid = models.IntegerField(primary_key=True)
>-    name = models.TextField()
>-
>-    def __str__(self):
>-        return "{}: {}".format(self.builderid, self.name)

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193729: 359907