Attachment 359891 Details for Bug 193722 – Patch

[patch] Patch

bug-193722-20190123083410.patch (text/plain), 2.10 KB, created by Jonathan Bedard on 2019-01-23 08:34:11 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-01-23 08:34:11 PST

Size: 2.10 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240336)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-01-23  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
>+        https://bugs.webkit.org/show_bug.cgi?id=193722
>+        <rdar://problem/47481475>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        iPhone and iPad ports should both use the iOS config.
>+
>+        * Scripts/webkitpy/port/ios_simulator.py:
>+        (IPhoneSimulatorPort.__init__):
>+        (IPadSimulatorPort.__init__):
>+
> 2019-01-23  Rob Buis  <rbuis@igalia.com>
> 
>         Update MIME type parser
>Index: Tools/Scripts/webkitpy/port/ios_simulator.py
>===================================================================
>--- Tools/Scripts/webkitpy/port/ios_simulator.py	(revision 240302)
>+++ Tools/Scripts/webkitpy/port/ios_simulator.py	(working copy)
>@@ -24,7 +24,7 @@ import logging
> 
> from webkitpy.common.memoized import memoized
> from webkitpy.common.version import Version
>-from webkitpy.port.config import apple_additions
>+from webkitpy.port.config import apple_additions, Config
> from webkitpy.port.ios import IOSPort
> from webkitpy.xcode.device_type import DeviceType
> from webkitpy.xcode.simulated_device import SimulatedDeviceManager
>@@ -120,9 +120,17 @@ class IPhoneSimulatorPort(IOSSimulatorPo
>         DeviceType(hardware_family='iPhone', hardware_type='7'),
>     ]
> 
>+    def __init__(self, *args, **kwargs):
>+        super(IPhoneSimulatorPort, self).__init__(*args, **kwargs)
>+        self._config = Config(self._executive, self._filesystem, IOSSimulatorPort.port_name)
>+
> 
> class IPadSimulatorPort(IOSSimulatorPort):
>     port_name = 'ipad-simulator'
> 
>     DEVICE_TYPE = DeviceType(hardware_family='iPad')
>     DEFAULT_DEVICE_TYPES = [DeviceType(hardware_family='iPad', hardware_type='(5th generation)')]
>+
>+    def __init__(self, *args, **kwargs):
>+        super(IPadSimulatorPort, self).__init__(*args, **kwargs)
>+        self._config = Config(self._executive, self._filesystem, IOSSimulatorPort.port_name)

Actions: View | Formatted Diff | Diff

Attachments on bug 193722: 359891