WebKit Bugzilla
Attachment 359887 Details for
Bug 193721
: [GTK] Crash when browsing inspector:// uri without port set
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193721-20190123161058.patch (text/plain), 1.72 KB, created by
Philippe Normand
on 2019-01-23 08:11:00 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Philippe Normand
Created:
2019-01-23 08:11:00 PST
Size:
1.72 KB
patch
obsolete
>Subversion Revision: 240334 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index b5d93a6b8ea8d9b205eb0a8507687d53a06eae12..2890220d20c61523e300e1cd39526eeffa3ad60b 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,15 @@ >+2019-01-23 Philippe Normand <pnormand@igalia.com> >+ >+ [GTK] Crash when browsing inspector:// uri without port set >+ https://bugs.webkit.org/show_bug.cgi?id=193721 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp: >+ (WebKit::RemoteInspectorProtocolHandler::handleRequest): Return >+ back to caller after setting the error, if no port was provided >+ along with the inspector URL. >+ > 2019-01-23 David Kilzer <ddkilzer@apple.com> > > Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h} >diff --git a/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp b/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp >index b7e6330eaeb2e2022e623f3a68ec1bc17aa3775d..3e98bce3157d99e7a4b9117ea74ca7046a1a822a 100644 >--- a/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp >+++ b/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp >@@ -92,6 +92,7 @@ void RemoteInspectorProtocolHandler::handleRequest(WebKitURISchemeRequest* reque > if (!requestURL.port()) { > GUniquePtr<GError> error(g_error_new_literal(WEBKIT_POLICY_ERROR, WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI, "Cannot show inspector URL: no port provided")); > webkit_uri_scheme_request_finish_error(request, error.get()); >+ return; > } > > auto* webView = webkit_uri_scheme_request_get_web_view(request);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
mcatanzaro
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193721
: 359887