WebKit Bugzilla
Attachment 359865 Details for
Bug 193711
: [DFG] AvailabilityMap::pruneByLiveness should make non-live operands Availability::unavailable instead of Availability()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193711-20190123024348.patch (text/plain), 1.97 KB, created by
Yusuke Suzuki
on 2019-01-23 02:43:49 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Yusuke Suzuki
Created:
2019-01-23 02:43:49 PST
Size:
1.97 KB
patch
obsolete
>Subversion Revision: 240297 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index c34ced4859fe3931fbbc2a2aa5f7cb5ce03beb94..2bbcd42854c133208ff3c6d42b93cf2a24a17d44 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,14 @@ >+2019-01-23 Yusuke Suzuki <ysuzuki@apple.com> >+ >+ [DFG] AvailabilityMap::pruneByLiveness should make non-live operands Availability::unavailable instead of Availability() >+ https://bugs.webkit.org/show_bug.cgi?id=193711 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * dfg/DFGAvailabilityMap.cpp: >+ (JSC::DFG::AvailabilityMap::pruneHeap): >+ (JSC::DFG::AvailabilityMap::pruneByLiveness): >+ > 2019-01-22 Yusuke Suzuki <ysuzuki@apple.com> > > [JSC] Intl constructors should fit in sizeof(InternalFunction) >diff --git a/Source/JavaScriptCore/dfg/DFGAvailabilityMap.cpp b/Source/JavaScriptCore/dfg/DFGAvailabilityMap.cpp >index 7855f8923506c16ca9cc834e03574d5b5a09651e..49135aa602b881dbcfe15bf1557f4bf74b6659af 100644 >--- a/Source/JavaScriptCore/dfg/DFGAvailabilityMap.cpp >+++ b/Source/JavaScriptCore/dfg/DFGAvailabilityMap.cpp >@@ -55,17 +55,15 @@ void AvailabilityMap::pruneHeap() > return possibleNodes.add(node).isNewEntry; > }); > >- HashMap<PromotedHeapLocation, Availability> newHeap; >- for (auto pair : m_heap) { >- if (possibleNodes.contains(pair.key.base())) >- newHeap.add(pair.key, pair.value); >+ for (auto& pair : m_heap) { >+ if (!possibleNodes.contains(pair.key.base())) >+ pair.value = Availability::unavailable(); > } >- m_heap = WTFMove(newHeap); > } > > void AvailabilityMap::pruneByLiveness(Graph& graph, CodeOrigin where) > { >- Operands<Availability> localsCopy(OperandsLike, m_locals); >+ Operands<Availability> localsCopy(m_locals.numberOfArguments(), m_locals.numberOfLocals(), Availability::unavailable()); > graph.forAllLiveInBytecode( > where, > [&] (VirtualRegister reg) {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193711
:
359865
|
359867
|
359868
|
359943
|
359948
|
359950