Attachment 359859 Details for Bug 193182 – Rebase on trunk

[patch] Rebase on trunk

bug-193182-20190122232926.patch (text/plain), 3.43 KB, created by Wenson Hsieh on 2019-01-22 23:29:27 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-01-22 23:29:27 PST

Size: 3.43 KB

patch

obsolete

>Subversion Revision: 240329
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 63044153f92110e072a217ecdbf1c1620bb7205e..a78faed9258cd650d49619efa4890ab52539a7e1 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
>+        https://bugs.webkit.org/show_bug.cgi?id=193182
>+        <rdar://problem/47452154>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix an existing bug where blurring an element doesn't always un-suppress text interactions.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _elementDidBlur]):
>+
> 2019-01-22  Chris Dumez  <cdumez@apple.com>
> 
>         Regression(r240178) Some API tests are crashing
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index d3f9f12efc6943bc0a41985b2faa0779ef34b535..609cd5b0769165ff49cc1ad6c935fd97f911a3e4 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -4660,6 +4660,7 @@ - (void)_elementDidBlur
> 
>     if (!_isChangingFocus) {
>         [self _stopSuppressingSelectionAssistantForReason:WebKit::FocusedElementIsTransparentOrFullyClipped];
>+        [self _stopSuppressingSelectionAssistantForReason:WebKit::FocusedElementIsTooSmall];
>         _didAccessoryTabInitiateFocus = NO;
>     }
> }
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 3165bd57825e4a320869675ccb0c47cdc1761266..eb2880dc1f5418950ecc56792cf6cf201e609894 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,23 @@
>+2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
>+        https://bugs.webkit.org/show_bug.cgi?id=193182
>+        <rdar://problem/47452154>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
>+        long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
>+        recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
>+
>+        To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
>+        preventing later tests from recognizing gestures.
>+
>+        * WebKitTestRunner/ios/TestControllerIOS.mm:
>+        (WTR::TestController::platformResetStateToConsistentValues):
>+
>+        Cancel all touches in the UIApplication when resetting to a consistent state between tests.
>+
> 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-app] fetch loop should not stop on network issues
>diff --git a/Tools/WebKitTestRunner/ios/TestControllerIOS.mm b/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
>index 855d2d5bc700340474c4271cc7b7aaa951020043..04011a6b3544837c559851730f699d76987214c3 100644
>--- a/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
>+++ b/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
>@@ -115,6 +115,7 @@ void TestController::platformResetStateToConsistentValues(const TestOptions& opt
> {
>     cocoaResetStateToConsistentValues(options);
> 
>+    [[UIApplication sharedApplication] _cancelAllTouches];
>     [[UIDevice currentDevice] setOrientation:UIDeviceOrientationPortrait animated:NO];
> 
>     m_inputModeSwizzlers.clear();

Actions: View | Formatted Diff | Diff

Attachments on bug 193182: 359387 | 359753 | 359859