Attachment 359811 Details for Bug 193048 – Patch - needs updated ChangeLog

[patch] Patch - needs updated ChangeLog

ToPostForReview.patch (text/plain), 3.21 KB, created by Daniel Bates on 2019-01-22 17:03:32 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-01-22 17:03:32 PST

Size: 3.21 KB

patch

obsolete

>From 4d80b6f232910da435d5cadcfe486253b177993c Mon Sep 17 00:00:00 2001
>From: Daniel Bates <dabates@apple.com>
>Date: Wed, 2 Jan 2019 10:02:31 -0800
>Subject: [PATCH] [iOS] Pressing Tab key doesn't move to next cell with Google
> Sheets https://bugs.webkit.org/show_bug.cgi?id=193048
> <rdar://problem/46433836>
>
>Reviewed by NOBODY (OOPS!).
>
>WebCore knows how interpret the Tab and Shift + Tab keys. When building with UIKit keyboard additions
>we do not need to register key commands for handling them from the UIProcess code. Instead UIKit will
>sends key events for these commands to us. This will make the behavior of these key commands when executed
>in an editable field match the behavior of these command when executed in a non-editable field since
>both code paths will now go through WebCore.
>
>* UIProcess/ios/WKContentViewInteraction.mm:
>(-[WKContentView keyCommands]): Deleted.
>---
> Source/WebKit/ChangeLog                         | 17 +++++++++++++++++
> .../UIProcess/ios/WKContentViewInteraction.mm   |  6 ++++++
> 2 files changed, 23 insertions(+)
>
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index c1ff4a4147d..fd106b2a599 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-01-02  Daniel Bates  <dabates@apple.com>
>+
>+        [iOS] Pressing Tab key doesn't move to next cell with Google Sheets
>+        https://bugs.webkit.org/show_bug.cgi?id=193048
>+        <rdar://problem/46433836>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WebCore knows how interpret the Tab and Shift + Tab keys. When building with UIKit keyboard additions
>+        we do not need to register key commands for handling them from the UIProcess code. Instead UIKit will
>+        sends key events for these commands to us. This will make the behavior of these key commands when executed
>+        in an editable field match the behavior of these command when executed in a non-editable field since
>+        both code paths will now go through WebCore.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView keyCommands]): Deleted.
>+
> 2018-01-08  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Interpret text key commands on keydown and app key commands on keypress
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 66818c6eae8..256c43b5202 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -1386,7 +1386,11 @@ - (BOOL)_requiresKeyboardWhenFirstResponder
>     case WebKit::InputType::Month:
>     case WebKit::InputType::DateTimeLocal:
>     case WebKit::InputType::Time:
>+#if USE(UIKIT_KEYBOARD_ADDITIONS)
>+        return YES;
>+#else
>         return !currentUserInterfaceIdiomIsPad();
>+#endif
>     default:
>         return !_focusedElementInformation.isReadOnly;
>     }
>@@ -3304,6 +3308,7 @@ - (void)accessoryDone
>     [self resignFirstResponder];
> }
> 
>+#if !USE(UIKIT_KEYBOARD_ADDITIONS)
> - (NSArray *)keyCommands
> {
>     if (!_page->editorState().isContentEditable)
>@@ -3315,6 +3320,7 @@ - (NSArray *)keyCommands
>     ] retain];
>     return editableKeyCommands;
> }
>+#endif
> 
> - (void)_nextAccessoryTabForWebView:(id)sender
> {
>-- 
>2.20.0 (Apple Git-115)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193048: 358120 | 358185 | 359811