Attachment 359806 Details for Bug 193690 – Patch

[patch] Patch

bug-193690-20190122163459.patch (text/plain), 8.08 KB, created by Simon Fraser (smfr) on 2019-01-22 16:35:00 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2019-01-22 16:35:00 PST

Size: 8.08 KB

patch

obsolete

>Subversion Revision: 240307
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ef50e528de5cc5d594003f08fb2f74dfd41b95b9..dad8ea054a700b754ea99b42967cd62c142ef28d 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,25 @@
>+2019-01-22  Simon Fraser  <simon.fraser@apple.com>
>+
>+        Make scrollingcoordinator tests only run on iOS/macOS WK2
>+        https://bugs.webkit.org/show_bug.cgi?id=193690
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        scrollingcoordinator is only active in WK2, and both WPE and WinCairo skip this directory
>+        already, so skip it at the top level, and re-enable for mac-wk2 and ios-wk2.
>+
>+        Add some iOS results for two tests.
>+
>+        Also do some cleanup after tiled-drawing/ios was removed on 1/18.
>+
>+        * TestExpectations:
>+        * platform/ios-device/TestExpectations:
>+        * platform/ios-wk2/TestExpectations:
>+        * platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
>+        * platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
>+        * platform/ios/TestExpectations:
>+        * platform/mac-wk2/TestExpectations:
>+
> 2019-01-22  Simon Fraser  <simon.fraser@apple.com>
> 
>         Remove an iOS quirk where iframe renderers are identified as "RenderPartObject" in layout test results
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 45fb8473254070926842f913f8261ee09d36433a..4223425d4905b0214b239bbd5cd2e4e5b13fe251 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -39,7 +39,7 @@ fast/events/touch/ios [ Skip ]
> fast/history/ios [ Skip ]
> fast/scrolling/ios [ Skip ]
> fast/text/mac [ Skip ]
>-scrollingcoordinator/ios [ Skip ]
>+scrollingcoordinator [ Skip ]
> fast/content-observation [ Skip ]
> media/mac [ Skip ]
> media/ios [ Skip ]
>diff --git a/LayoutTests/platform/ios-device/TestExpectations b/LayoutTests/platform/ios-device/TestExpectations
>index 633c43b199274b78e1e9ad55088264986db05950..4d7352e36c54e5ff59ca63076f491740f59fea57 100644
>--- a/LayoutTests/platform/ios-device/TestExpectations
>+++ b/LayoutTests/platform/ios-device/TestExpectations
>@@ -120,8 +120,6 @@ media/invalid-media-url-crash.html [ Crash ]
> 
> svg/custom/pattern-reference.svg [ Crash ]
> 
>-tiled-drawing/ios/iphone7/compositing-layers-deep-color.html [ Failure ]
>-
> quicklook/numbers.html [ ImageOnlyFailure ]
> 
> scrollbars/overflow-scrollbar-combinations.html [ Timeout ]
>@@ -131,7 +129,6 @@ security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.htm
> security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html [ ImageOnlyFailure ]
> 
> # <https://bugs.webkit.org/show_bug.cgi?id=175987> Manage tests which require different device types better
>-tiled-drawing/ios/iphone7
> fast/forms/ios/ipad
> fast/events/touch/ios/iphone7
> 
>diff --git a/LayoutTests/platform/ios-wk2/TestExpectations b/LayoutTests/platform/ios-wk2/TestExpectations
>index c1f677fd29ca8baadeb21738b452ff09d8390af4..43fc8a61bd408f3b8b5268b67be9072e804074f7 100644
>--- a/LayoutTests/platform/ios-wk2/TestExpectations
>+++ b/LayoutTests/platform/ios-wk2/TestExpectations
>@@ -11,8 +11,7 @@ fast/history/ios [ Pass ]
> fast/scrolling/ios [ Pass ]
> fast/viewport/ios [ Pass ]
> fast/visual-viewport/ios/ [ Pass ]
>-scrollingcoordinator/ios [ Pass ]
>-tiled-drawing/ios [ Pass ]
>+scrollingcoordinator [ Pass ]
> fast/web-share [ Pass ]
> editing/find [ Pass ]
> editing/input/ios [ Pass ]
>@@ -1190,6 +1189,7 @@ fast/css/deferred-parsing/hover-test.html [ Skip ]
> fast/events/context-activated-by-key-event.html [ Skip ]
> 
> webkit.org/b/168924 scrollingcoordinator/ios/non-stable-viewport-scroll.html [ Pass Failure ]
>+webkit.org/b/171628 scrollingcoordinator/ios/nested-fixed-layer-positions.html [ Pass ImageOnlyFailure ]
> 
> webkit.org/b/169640 imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-javascript.html [ Failure ]
> 
>@@ -1217,8 +1217,6 @@ webkit.org/b/171331 http/tests/preload/single_download_preload.html [ Pass Failu
> 
> webkit.org/b/170699 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html [ Pass Failure ]
> 
>-webkit.org/b/171628 scrollingcoordinator/ios/nested-fixed-layer-positions.html [ Pass ImageOnlyFailure ]
>-
> webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ]
> 
> webkit.org/b/171830 [ Debug ] http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]
>diff --git a/LayoutTests/platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt b/LayoutTests/platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..23868a8a4c6c8dac52bf7993d36300e74c1d6715
>--- /dev/null
>+++ b/LayoutTests/platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt
>@@ -0,0 +1,12 @@
>+layer at (0,0) size 800x600
>+  RenderView at (0,0) size 800x600
>+layer at (0,0) size 800x8
>+  RenderBlock {HTML} at (0,0) size 800x8
>+    RenderBody {BODY} at (8,8) size 784x0
>+layer at (50,50) size 324x224
>+  RenderIFrame {IFRAME} at (50,50) size 324x224 [border: (2px inset #000000)]
>+    layer at (0,0) size 1008x1016
>+      RenderView at (0,0) size 300x200
>+    layer at (0,0) size 300x1016
>+      RenderBlock {HTML} at (0,0) size 300x1016
>+        RenderBody {BODY} at (8,8) size 1000x1000
>diff --git a/LayoutTests/platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt b/LayoutTests/platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..74e3b1e44331fc2095029cb082f15756b5c5e5d1
>--- /dev/null
>+++ b/LayoutTests/platform/ios-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt
>@@ -0,0 +1,12 @@
>+layer at (0,0) size 800x600
>+  RenderView at (0,0) size 800x600
>+layer at (0,0) size 800x8
>+  RenderBlock {HTML} at (0,0) size 800x8
>+    RenderBody {BODY} at (8,8) size 784x0
>+layer at (200,150) size 324x224
>+  RenderIFrame {IFRAME} at (200,150) size 324x224 [border: (2px inset #000000)]
>+    layer at (0,0) size 1008x1016
>+      RenderView at (0,0) size 300x200
>+    layer at (0,0) size 300x1016
>+      RenderBlock {HTML} at (0,0) size 300x1016
>+        RenderBody {BODY} at (8,8) size 1000x1000
>diff --git a/LayoutTests/platform/ios/TestExpectations b/LayoutTests/platform/ios/TestExpectations
>index 49dd3f62eaa93b623958564101387ca50a112558..2b3325b9a27ec5da26f0d071c48b5b48c17b1aff 100644
>--- a/LayoutTests/platform/ios/TestExpectations
>+++ b/LayoutTests/platform/ios/TestExpectations
>@@ -1531,10 +1531,6 @@ svg/zoom/text/zoom-svg-float-border-padding.xml [ Failure ]
> transforms/3d/point-mapping/3d-point-mapping-3.html [ Failure ]
> transforms/3d/point-mapping/3d-point-mapping-overlapping.html [ Failure ]
> 
>-# Scrolling coordinator tests that fail:
>-scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ Failure ]
>-scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ Failure ]
>-
> # Userscript tests that fail:
> userscripts/user-script-plugin-document.html [ Failure ]
> 
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index c6e82448669e35f68bd0ff0b47a644363f85a80e..8d852f0ce342edf6c64600c2ca374e88064760c5 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -5,13 +5,14 @@
> # Platform-specific directories. Skipped globally, then re-enabled here.
> #//////////////////////////////////////////////////////////////////////////////////////////
> 
>-tiled-drawing [ Pass ]
>-tiled-drawing/ios [ Skip ]
>-fast/visual-viewport/tiled-drawing [ Pass ]
>-swipe [ Pass ]
>-fast/web-share [ Pass ]
> editing/find [ Pass ]
> editing/undo-manager [ Pass ]
>+fast/visual-viewport/tiled-drawing [ Pass ]
>+fast/web-share [ Pass ]
>+scrollingcoordinator [ Pass ]
>+scrollingcoordinator/ios [ Skip ]
>+swipe [ Pass ]
>+tiled-drawing [ Pass ]
> 
> fast/events/autoscroll-when-zoomed.html [ Pass ]
> fast/events/autoscroll-main-document.html [ Pass ]

Flags:

zalan: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 193690: 359787 | 359806 | 359836