WebKit Bugzilla
Attachment 359791 Details for
Bug 193687
: Long presses on YouTube links incorrectly trigger a load
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193687-20190122154826.patch (text/plain), 2.56 KB, created by
Megan Gardner
on 2019-01-22 15:48:27 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Megan Gardner
Created:
2019-01-22 15:48:27 PST
Size:
2.56 KB
patch
obsolete
>Subversion Revision: 240297 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 89afd9d745b6039267b833958ef847a4942dff08..aa2f1b5f27f10ca172830c67ef36e5038ce8da9a 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,18 @@ >+2019-01-22 Megan Gardner <megan_gardner@apple.com> >+ >+ Cancel Web Touches Properly so that long presses on YouTube links do not incorrectly trigger a load >+ https://bugs.webkit.org/show_bug.cgi?id=193687 >+ <rdar://problem/47056717> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Cancel web gestures when a long press is recognized. >+ >+ * Platform/spi/ios/UIKitSPI.h: >+ * UIProcess/ios/WKContentViewInteraction.mm: >+ (-[WKContentView _cancelWebGestureRecognizer]): >+ (-[WKContentView _longPressRecognized:]): >+ > 2019-01-22 Alex Christensen <achristensen@webkit.org> > > Fix more builds. >diff --git a/Source/WebKit/Platform/spi/ios/UIKitSPI.h b/Source/WebKit/Platform/spi/ios/UIKitSPI.h >index 7a8e870b9524e95998ce1ed1de8cdb310d3a7b94..b5c3e34c21cc09dc0cd3ea8c4d7aff2e58fb45db 100644 >--- a/Source/WebKit/Platform/spi/ios/UIKitSPI.h >+++ b/Source/WebKit/Platform/spi/ios/UIKitSPI.h >@@ -758,6 +758,7 @@ struct _UIWebTouchEvent { > > @interface UIWebTouchEventsGestureRecognizer () > - (id)initWithTarget:(id)target action:(SEL)action touchDelegate:(id <UIWebTouchEventsGestureRecognizerDelegate>)delegate; >+- (void)cancel; > @property (nonatomic, getter=isDefaultPrevented) BOOL defaultPrevented; > @property (nonatomic, readonly) BOOL inJavaScriptGesture; > @property (nonatomic, readonly) CGPoint locationInWindow; >diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >index 66818c6eae8971c7a4c0e260599c357ff1a836c8..2ec37812a75fcd38d1a70b26fb723aa45ba44585 100644 >--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm >@@ -1348,6 +1348,13 @@ - (void)_cancelLongPressGestureRecognizer > [_highlightLongPressGestureRecognizer cancel]; > } > >+- (void)_cancelWebGestureRecognizer >+{ >+#if HAVE(CANCEL_WEB_TOUCH_EVENTS_GESTURE) >+ [_touchEventGestureRecognizer cancel]; >+#endif >+} >+ > - (void)_didScroll > { > [self _cancelLongPressGestureRecognizer]; >@@ -1979,6 +1986,7 @@ - (void)_longPressRecognized:(UILongPressGestureRecognizer *)gestureRecognizer > { > ASSERT(gestureRecognizer == _longPressGestureRecognizer); > [self _resetIsDoubleTapPending]; >+ [self _cancelWebGestureRecognizer]; > > _lastInteractionLocation = gestureRecognizer.startPoint; >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193687
:
359780
|
359786
|
359791
|
359825