Attachment 359761 Details for Bug 192730 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

table-1.patch (text/plain), 1.96 KB, created by Joseph Pecoraro on 2019-01-22 12:13:28 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-01-22 12:13:28 PST

Size: 1.96 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b56793b9ad0..f0c74bcbf86 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-22  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Web Inspector: Network Table appears broken after filter - rows look collapsed
>+        https://bugs.webkit.org/show_bug.cgi?id=192730
>+        <rdar://problem/46853158>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/Table.js:
>+        (WI.Table.prototype._applyColumnWidthsToColumnsIfNeeded):
>+        Affect the filler row like the other applyColumnWidths calls since this
>+        now may be the initial call to size visible columns.
>+
> 2019-01-17  Truitt Savell  <tsavell@apple.com>
> 
>         Unreviewed, rolling out r240124.
>diff --git a/Source/WebInspectorUI/UserInterface/Views/Table.js b/Source/WebInspectorUI/UserInterface/Views/Table.js
>index 2bc6f34b602..35202477c40 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/Table.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/Table.js
>@@ -1153,11 +1153,13 @@ WI.Table = class Table extends WI.View
>     {
>         // Apply and create missing cells only if row needs a width update.
>         for (let row of this._listElement.children) {
>-            if (row.__widthGeneration !== this._widthGeneration && row !== this._fillerRow) {
>+            if (row.__widthGeneration !== this._widthGeneration) {
>                 for (let i = 0; i < row.children.length; ++i)
>                     row.children[i].style.width = this._columnWidths[i] + "px";
>-                if (row.children.length !== this._visibleColumns.length)
>-                    this._populateRow(row);
>+                if (row !== this._fillerRow) {
>+                    if (row.children.length !== this._visibleColumns.length)
>+                        this._populateRow(row);
>+                }
>                 row.__widthGeneration = this._widthGeneration;
>             }
>         }

Actions: View | Formatted Diff | Diff

Attachments on bug 192730: 357457 | 359761