Attachment 359753 Details for Bug 193182 – Patch

[patch] Patch

bug-193182-20190122110944.patch (text/plain), 2.98 KB, created by Wenson Hsieh on 2019-01-22 11:09:45 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-01-22 11:09:45 PST

Size: 2.98 KB

patch

obsolete

>Subversion Revision: 240102
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 9561f9f31f0ded6cd814fb5ded88e4078011f3e8..64bb598220b6e23fbf4bcd7f293de2730571c54d 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
>+        https://bugs.webkit.org/show_bug.cgi?id=193182
>+        <rdar://problem/47452154>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix an existing bug where blurring an element doesn't always un-suppress text interactions.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _elementDidBlur]):
>+
> 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 3e5292a78c2acf461a68293b3aac422c90d7b3c5..8d0b6437db231e1a8a4be3833b4357a09284e3c4 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -4634,6 +4634,7 @@ - (void)_elementDidBlur
> 
>     if (!_isChangingFocus) {
>         [self _stopSuppressingSelectionAssistantForReason:WebKit::FocusedElementIsTransparentOrFullyClipped];
>+        [self _stopSuppressingSelectionAssistantForReason:WebKit::FocusedElementIsTooSmall];
>         _didAccessoryTabInitiateFocus = NO;
>     }
> }
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 18edb5f98eb86cd76f8e45185203b02abec3f83a..3c3cb9f32a283fb50da4d30d32022a75f071fca6 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
>+        https://bugs.webkit.org/show_bug.cgi?id=193182
>+        <rdar://problem/47452154>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Clear active touches between test invocations.
>+
>+        * WebKitTestRunner/ios/TestControllerIOS.mm:
>+        (WTR::TestController::platformResetStateToConsistentValues):
>+
> 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
>diff --git a/Tools/WebKitTestRunner/ios/TestControllerIOS.mm b/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
>index 855d2d5bc700340474c4271cc7b7aaa951020043..04011a6b3544837c559851730f699d76987214c3 100644
>--- a/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
>+++ b/Tools/WebKitTestRunner/ios/TestControllerIOS.mm
>@@ -115,6 +115,7 @@ void TestController::platformResetStateToConsistentValues(const TestOptions& opt
> {
>     cocoaResetStateToConsistentValues(options);
> 
>+    [[UIApplication sharedApplication] _cancelAllTouches];
>     [[UIDevice currentDevice] setOrientation:UIDeviceOrientationPortrait animated:NO];
> 
>     m_inputModeSwizzlers.clear();

Actions: View | Formatted Diff | Diff

Attachments on bug 193182: 359387 | 359753 | 359859