Attachment 359750 Details for Bug 193675 – Patch

[patch] Patch

bug-193675-20190122110552.patch (text/plain), 4.04 KB, created by Devin Rousso on 2019-01-22 11:05:53 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-01-22 11:05:53 PST

Size: 4.04 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index fe668cfe686e68d163f119b1ca5c983d1c2f7843..8e9e9071b89cd37b10bbc1eaf2714e7bcd97dd0f 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-01-22  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Audit: use plural strings for Passed, Failed, and Unsupported
>+        https://bugs.webkit.org/show_bug.cgi?id=193675
>+        <rdar://problem/46628680>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/AuditTestGroupContentView.js:
>+        (WI.AuditTestGroupContentView.prototype.layout):
>+
>+        * Localizations/en.lproj/localizedStrings.js:
>+
> 2019-01-18  Jer Noble  <jer.noble@apple.com>
> 
>         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
>diff --git a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>index 61d2f6d6bd12e061a06939f58c625ef646fae4b4..a6ac3b2ca2d6546e686146245cb351a03b66c5ed 100644
>--- a/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>+++ b/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
>@@ -25,13 +25,16 @@ localizedStrings["%.3fms"] = "%.3fms";
> localizedStrings["%d Error"] = "%d Error";
> localizedStrings["%d Errors"] = "%d Errors";
> localizedStrings["%d Errors, %d Warnings"] = "%d Errors, %d Warnings";
>-localizedStrings["%d Failed"] = "%d Failed";
>+localizedStrings["%d Failed (plural)"] = "%d Failed";
>+localizedStrings["%d Failed (singular)"] = "%d Failed";
> localizedStrings["%d Frame"] = "%d Frame";
> localizedStrings["%d Frames"] = "%d Frames";
> localizedStrings["%d More\u2026"] = "%d More\u2026";
>-localizedStrings["%d Passed"] = "%d Passed";
>+localizedStrings["%d Passed (plural)"] = "%d Passed";
>+localizedStrings["%d Passed (singular)"] = "%d Passed";
> localizedStrings["%d Threads"] = "%d Threads";
>-localizedStrings["%d Unsupported"] = "%d Unsupported";
>+localizedStrings["%d Unsupported (plural)"] = "%d Unsupported";
>+localizedStrings["%d Unsupported (singular)"] = "%d Unsupported";
> localizedStrings["%d Warning"] = "%d Warning";
> localizedStrings["%d Warnings"] = "%d Warnings";
> localizedStrings["%d \xd7 %d pixels"] = "%d \xd7 %d pixels";
>diff --git a/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js b/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js
>index d5bbec5c5c20f5956d36172b9b7af02609dddcfe..7ff0a1e766f23a75a92c1f5c4ceb295d68bf998c 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js
>@@ -122,11 +122,11 @@ WI.AuditTestGroupContentView = class AuditTestGroupContentView extends WI.AuditT
>                 scopeBarItems.push(scopeBarItem);
>             };
> 
>-            addScopeBarItem(WI.AuditTestCaseResult.Level.Pass, WI.UIString("%d Passed"));
>+            addScopeBarItem(WI.AuditTestCaseResult.Level.Pass, WI.UIString("%d Passed", "%d Passed (singular)"), WI.UIString("%d Passed", "%d Passed (plural)"));
>             addScopeBarItem(WI.AuditTestCaseResult.Level.Warn, WI.UIString("%d Warning"), WI.UIString("%d Warnings"));
>-            addScopeBarItem(WI.AuditTestCaseResult.Level.Fail, WI.UIString("%d Failed"));
>+            addScopeBarItem(WI.AuditTestCaseResult.Level.Fail, WI.UIString("%d Failed", "%d Failed (singular)"), WI.UIString("%d Failed", "%d Failed (plural)"));
>             addScopeBarItem(WI.AuditTestCaseResult.Level.Error, WI.UIString("%d Error"), WI.UIString("%d Errors"));
>-            addScopeBarItem(WI.AuditTestCaseResult.Level.Unsupported, WI.UIString("%d Unsupported"));
>+            addScopeBarItem(WI.AuditTestCaseResult.Level.Unsupported, WI.UIString("%d Unsupported", "%d Unsupported (singular)"), WI.UIString("%d Unsupported", "%d Unsupported (plural)"));
> 
>             this._levelScopeBar = new WI.ScopeBar(null, scopeBarItems);
>             this._levelScopeBar.addEventListener(WI.ScopeBar.Event.SelectionChanged, this._handleLevelScopeBarSelectionChanged, this);

Actions: View | Formatted Diff | Diff

Attachments on bug 193675: 359750