Attachment 359743 Details for Bug 193673 – Patch v1

[patch] Patch v1

bug-193673-20190122094209.patch (text/plain), 1.55 KB, created by David Kilzer (:ddkilzer) on 2019-01-22 09:42:10 PST

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2019-01-22 09:42:10 PST

Size: 1.55 KB

patch

obsolete

>Subversion Revision: 240252
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 84752c51907f42dd7f58a9c9a28ab13cf081b76b..875c1e4744adbdd1ef31fbd6d7c96f981c0c70a3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-22  David Kilzer  <ddkilzer@apple.com>
>+
>+        Leak of NSMutableArray (128 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
>+        <https://webkit.org/b/193673>
>+        <rdar://problem/47448241>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:
>+        (WebCore::appendArgumentToArray): Use adoptNS() to fix the leak.
>+
> 2019-01-22  Frederic Wang  <fwang@igalia.com>
> 
>         Minor refactoring of the scrolling code
>diff --git a/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm b/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm
>index 13b8f80668d7b9637f7cec1388ee1eac069433c0..408bbb5004960b7fce484983550aadb04d9b55b8 100644
>--- a/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm
>+++ b/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm
>@@ -55,7 +55,7 @@ static void appendArgumentToArray(ArgumentArray& array, RetainPtr<MTLArgumentDes
> {
>     BEGIN_BLOCK_OBJC_EXCEPTIONS;
>     if (!array)
>-        array = [[NSMutableArray alloc] initWithObjects:argument.get(), nil];
>+        array = adoptNS([[NSMutableArray alloc] initWithObjects:argument.get(), nil]);
>     else
>         [array addObject:argument.get()];
>     END_BLOCK_OBJC_EXCEPTIONS;

Actions: View | Formatted Diff | Diff

Attachments on bug 193673: 359743