Attachment 359742 Details for Bug 193669 – Proposed patch

[patch] Proposed patch

bwo-unit-test-fix-v2.patch (text/plain), 1.51 KB, created by Aakash Jain on 2019-01-22 09:39:45 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-22 09:39:45 PST

Size: 1.51 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240253)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-22  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [build.webkit.org] Unit-test failure after r237113
>+        https://bugs.webkit.org/show_bug.cgi?id=193669
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/build.webkit.org-config/factories.py:
>+        (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
>+        multiple or zero flags.
>+
> 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
> 
>         [css-logical] Implement flow-relative margin, padding and border shorthands
>Index: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py
>===================================================================
>--- Tools/BuildSlaveSupport/build.webkit.org-config/factories.py	(revision 240253)
>+++ Tools/BuildSlaveSupport/build.webkit.org-config/factories.py	(working copy)
>@@ -39,7 +39,7 @@ class Factory(factory.BuildFactory):
>         self.addStep(DeleteStaleBuildFiles())
>         if platform == "win":
>             self.addStep(InstallWin32Dependencies())
>-        if platform == "gtk" and additionalArguments != ["--no-experimental-features"]:
>+        if platform == "gtk" and "--no-experimental-features" not in (additionalArguments or []):
>             self.addStep(InstallGtkDependencies())
>         if platform == "wpe":
>             self.addStep(InstallWpeDependencies())

Actions: View | Formatted Diff | Diff

Attachments on bug 193669: 359734 | 359742 | 359752