Attachment 359732 Details for Bug 193585 – Patch

[patch] Patch

bug-193585-20190122065744.patch (text/plain), 5.14 KB, created by Gurdal Oruklu on 2019-01-22 06:57:45 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Gurdal Oruklu

Created: 2019-01-22 06:57:45 PST

Size: 5.14 KB

patch

obsolete

>Subversion Revision: 240155
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 927032f3b170c207eb385a98aab9de74eabf284a..aa70f4d9f114558b1303de9b74514bf35ce29389 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-18  Manigandan Gopalakirshnan  <Manigandan_Gopalakirshnan@cable.comcast.com>
>+
>+        TestController should set media cache directory properly
>+        https://bugs.webkit.org/show_bug.cgi?id=193585
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use WKContextConfiguration in TestController to set the media cache directory
>+
>+        * UIProcess/API/C/WKContextConfigurationRef.cpp:
>+        (WKContextConfigurationCopyMediaCacheDirectory):
>+        (WKContextConfigurationSetMediaCacheDirectory):
>+        * UIProcess/API/C/WKContextConfigurationRef.h:
>+
> 2019-01-18  Philippe Normand  <pnormand@igalia.com>
> 
>         [WPE] Add Qt extension
>diff --git a/Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp b/Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp
>index 86d41299dfaab3d64e7c41e060c02f661cd1c37e..fdd55dd2bbc403aa6d80cb92ec21214a7f55461c 100644
>--- a/Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp
>+++ b/Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp
>@@ -118,6 +118,16 @@ void WKContextConfigurationSetMediaKeysStorageDirectory(WKContextConfigurationRe
>     toImpl(configuration)->setMediaKeysStorageDirectory(toImpl(mediaKeysStorageDirectory)->string());
> }
> 
>+WKStringRef WKContextConfigurationCopyMediaCacheDirectory(WKContextConfigurationRef configuration)
>+{
>+    return toCopiedAPI(toImpl(configuration)->mediaCacheDirectory());
>+}
>+
>+void WKContextConfigurationSetMediaCacheDirectory(WKContextConfigurationRef configuration, WKStringRef mediaCacheDirectory)
>+{
>+    toImpl(configuration)->setMediaCacheDirectory(toImpl(mediaCacheDirectory)->string());
>+}
>+
> WKStringRef WKContextConfigurationCopyResourceLoadStatisticsDirectory(WKContextConfigurationRef configuration)
> {
>     return toCopiedAPI(toImpl(configuration)->resourceLoadStatisticsDirectory());
>diff --git a/Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h b/Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h
>index 32694172c5784d9380a3d4ca06924a5f1fd4efaa..bf377c00e90b8d0f00d06e01dfa75bd63d44e53d 100644
>--- a/Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h
>+++ b/Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h
>@@ -57,6 +57,9 @@ WK_EXPORT void WKContextConfigurationSetWebSQLDatabaseDirectory(WKContextConfigu
> WK_EXPORT WKStringRef WKContextConfigurationCopyMediaKeysStorageDirectory(WKContextConfigurationRef configuration);
> WK_EXPORT void WKContextConfigurationSetMediaKeysStorageDirectory(WKContextConfigurationRef configuration, WKStringRef mediaKeysStorageDirectory);
> 
>+WK_EXPORT WKStringRef WKContextConfigurationCopyMediaCacheDirectory(WKContextConfigurationRef configuration);
>+WK_EXPORT void WKContextConfigurationSetMediaCacheDirectory(WKContextConfigurationRef configuration, WKStringRef mediaCacheDirectory);
>+
> WK_EXPORT WKStringRef WKContextConfigurationCopyResourceLoadStatisticsDirectory(WKContextConfigurationRef configuration);
> WK_EXPORT void WKContextConfigurationSetResourceLoadStatisticsDirectory(WKContextConfigurationRef configuration, WKStringRef resourceLoadStatisticsDirectory);
> 
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 235dcd199f85eed1de0ec22854cf1dc97c8c1433..78a383f14fe078e07515ad04caf3c5c64cfd89f0 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-18  Manigandan Gopalakirshnan  <Manigandan_Gopalakirshnan@cable.comcast.com>
>+
>+        TestController should set media cache directory properly
>+        https://bugs.webkit.org/show_bug.cgi?id=193585
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use WKContextConfiguration in TestController to set the media cache directory
>+
>+        * WebKitTestRunner/TestController.cpp:
>+        (WTR::TestController::generateContextConfiguration const):
>+
> 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-build] Pass owner to the triggered builds
>diff --git a/Tools/WebKitTestRunner/TestController.cpp b/Tools/WebKitTestRunner/TestController.cpp
>index 926177ef2c7729b48a3bc037a41a1b6f2c4382d3..e2225c01bfcd90e6f45f5e587df7f04d737a30e5 100644
>--- a/Tools/WebKitTestRunner/TestController.cpp
>+++ b/Tools/WebKitTestRunner/TestController.cpp
>@@ -459,6 +459,7 @@ WKRetainPtr<WKContextConfigurationRef> TestController::generateContextConfigurat
>         WKContextConfigurationSetLocalStorageDirectory(configuration.get(), toWK(temporaryFolder + separator + "LocalStorage").get());
>         WKContextConfigurationSetWebSQLDatabaseDirectory(configuration.get(), toWK(temporaryFolder + separator + "Databases" + separator + "WebSQL").get());
>         WKContextConfigurationSetMediaKeysStorageDirectory(configuration.get(), toWK(temporaryFolder + separator + "MediaKeys").get());
>+        WKContextConfigurationSetMediaCacheDirectory(configuration.get(), toWK(temporaryFolder + separator + "MediaCache").get());
>         WKContextConfigurationSetResourceLoadStatisticsDirectory(configuration.get(), toWK(temporaryFolder + separator + "ResourceLoadStatistics").get());
>     }
>     return configuration;

Flags:

achristensen: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 193585: 359528 | 359732