Attachment 359726 Details for Bug 193664 – Patch

[patch] Patch

bug-193664-20190122193736.patch (text/plain), 1.74 KB, created by Fujii Hironori on 2019-01-22 02:37:37 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-01-22 02:37:37 PST

Size: 1.74 KB

patch

obsolete

>Subversion Revision: 240248
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2e4eb3a2cf9427c55cb43b0e27b17c40cf696190..fc291e67b7c71321041bef5ff07f5c0639b79856 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-01-22  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [WinCairo][WebKitTestRunner] Null dereference of GraphicsContext::m_data in GraphicsContext::releaseWindowsContext
>+        https://bugs.webkit.org/show_bug.cgi?id=193664
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WinCairo WebKitTestRunner always crash on openning test cases of
>+        HTMLMeterElement.
>+
>+        If GraphicsContext::getWindowsContext retruned null HDC,
>+        LocalWindowsContext shouldn't release the null HDC.
>+
>+        Covered by existing tests.
>+
>+        * platform/graphics/win/LocalWindowsContext.h:
>+        (WebCore::LocalWindowsContext::~LocalWindowsContext):
>+        Release m_hdc only if it isn't null.
>+
> 2019-01-21  Brent Fulgham  <bfulgham@apple.com>
> 
>         Implement message handlers for NetworkProcess-based ResourceLoadStatistics
>diff --git a/Source/WebCore/platform/graphics/win/LocalWindowsContext.h b/Source/WebCore/platform/graphics/win/LocalWindowsContext.h
>index 93450ef815aeddb6ef91ae73186ae329ea424686..e2bf1d1d2df62343ffc455ba7a8d7ce2fb7330bc 100644
>--- a/Source/WebCore/platform/graphics/win/LocalWindowsContext.h
>+++ b/Source/WebCore/platform/graphics/win/LocalWindowsContext.h
>@@ -43,7 +43,8 @@ public:
> 
>     ~LocalWindowsContext()
>     {
>-        m_graphicsContext.releaseWindowsContext(m_hdc, m_rect, m_supportAlphaBlend);
>+        if (m_hdc)
>+            m_graphicsContext.releaseWindowsContext(m_hdc, m_rect, m_supportAlphaBlend);
>     }
> 
>     HDC hdc() const { return m_hdc; }

Actions: View | Formatted Diff | Diff

Attachments on bug 193664: 359726 | 359997