Attachment 359722 Details for Bug 189472 – Patch for landing

[patch] Patch for landing

bug-189472-20190122092948.patch (text/plain), 2.08 KB, created by Frédéric Wang (:fredw) on 2019-01-22 00:29:50 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Wang (:fredw)

Created: 2019-01-22 00:29:50 PST

Size: 2.08 KB

patch

obsolete

>Subversion Revision: 240249
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index bc5da368c20a388616b725680e07c6332d80b137..8596d6bb1644f2eec8d583b2f1bc5596da0748fb 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,22 @@
>+2018-09-24  Frederic Wang  <fwang@igalia.com>
>+
>+        Enable CSSOMViewScrollingAPI
>+        https://bugs.webkit.org/show_bug.cgi?id=189472
>+
>+        Reviewed by Simon Fraser.
>+
>+        This patch enables the CSSOMViewScrollingAPI option by default. This feature has already been
>+        enabled in tests since r235855. Basically, this change fixes an old compatibility issue
>+        regarding which scrolling element correspond to the viewport in standard mode (WebKit uses
>+        document.body while Gecko/Edge/Chromium use document.documentElement as described in the
>+        CSSOM View specification). WebKit developers writing tests can use document.scrollingElement
>+        for that purpose, so that they work independently of whether the option is enabled.
>+
>+        [1] https://lists.webkit.org/pipermail/webkit-dev/2018-January/029857.html
>+
>+        * Shared/WebPreferences.yaml: Enable by default and remove "experimental" category in
>+        accordance with the new policy. Instead, keep an internal flag only for developers.
>+
> 2019-01-21  Antti Koivisto  <antti@apple.com>
> 
>         [iOS] Handle hit testing for subframes
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 82ddcbcc0c62ff68d949aa0a1be4c2fb6956d141..024322a438e67cfb806589db7cba9af065ebabe0 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -1255,10 +1255,10 @@ PointerEventsEnabled:
> 
> CSSOMViewScrollingAPIEnabled:
>   type: bool
>-  defaultValue: false
>+  defaultValue: true
>   humanReadableName: "CSSOM View Scrolling API"
>   humanReadableDescription: "Implement standard behavior for scrollLeft, scrollTop, scrollWidth, scrollHeight, scrollTo, scrollBy and scrollingElement."
>-  category: experimental
>+  category: internal
> 
> WebAnimationsEnabled:
>   type: bool

Actions: View | Formatted Diff | Diff

Attachments on bug 189472: 349300 | 350628 | 353163 | 359722