WebKit Bugzilla
Attachment 359712 Details for
Bug 193662
: [JSC] StrictModeTypeErrorFunction is no longer used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193662-20190121164333.patch (text/plain), 6.02 KB, created by
Yusuke Suzuki
on 2019-01-21 16:43:34 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Yusuke Suzuki
Created:
2019-01-21 16:43:34 PST
Size:
6.02 KB
patch
obsolete
>Subversion Revision: 240244 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index e37e391217f7e839e9b35b0d322ebfc3657a1030..9b6482d67468662017121092c8fe3fe63538070e 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,21 @@ >+2019-01-21 Yusuke Suzuki <ysuzuki@apple.com> >+ >+ [JSC] StrictModeTypeErrorFunction is no longer used >+ https://bugs.webkit.org/show_bug.cgi?id=193662 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ StrictModeTypeErrorFunction is no longer used. This patch drops it. Furthermore, it also allows us to drop >+ strictModeTypeErrorFunctionSpace from VM. >+ >+ * runtime/Error.cpp: >+ (JSC::StrictModeTypeErrorFunction::destroy): Deleted. >+ * runtime/Error.h: >+ (): Deleted. >+ * runtime/VM.cpp: >+ (JSC::VM::VM): >+ * runtime/VM.h: >+ > 2019-01-21 Caio Lima <ticaiolima@gmail.com> > > DoesGC rule is wrong for nodes with BigIntUse >diff --git a/Source/JavaScriptCore/runtime/Error.cpp b/Source/JavaScriptCore/runtime/Error.cpp >index 6388e4ed3c93848f776a5973a2028875a5a46bec..d93344097a13e0330a50c1410e5cc75bbe5ed46d 100644 >--- a/Source/JavaScriptCore/runtime/Error.cpp >+++ b/Source/JavaScriptCore/runtime/Error.cpp >@@ -361,14 +361,6 @@ JSObject* createOutOfMemoryError(ExecState* exec, const String& message) > return error; > } > >- >-const ClassInfo StrictModeTypeErrorFunction::s_info = { "Function", &Base::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(StrictModeTypeErrorFunction) }; >- >-void StrictModeTypeErrorFunction::destroy(JSCell* cell) >-{ >- static_cast<StrictModeTypeErrorFunction*>(cell)->StrictModeTypeErrorFunction::~StrictModeTypeErrorFunction(); >-} >- > } // namespace JSC > > namespace WTF { >diff --git a/Source/JavaScriptCore/runtime/Error.h b/Source/JavaScriptCore/runtime/Error.h >index 0d0a0b5cf6d82d428ea87463f165232f2c1691ef..f94b005b8304ba4ba50a7d32601b227a7c9d809f 100644 >--- a/Source/JavaScriptCore/runtime/Error.h >+++ b/Source/JavaScriptCore/runtime/Error.h >@@ -104,59 +104,6 @@ inline EncodedJSValue throwVMTypeError(ExecState* exec, ThrowScope& scope, const > inline EncodedJSValue throwVMRangeError(ExecState* state, ThrowScope& scope, const String& errorMessage) { return JSValue::encode(throwRangeError(state, scope, errorMessage)); } > inline EncodedJSValue throwVMDOMAttributeGetterTypeError(ExecState* state, ThrowScope& scope, const ClassInfo* classInfo, PropertyName propertyName) { return JSValue::encode(throwDOMAttributeGetterTypeError(state, scope, classInfo, propertyName)); } > >-class StrictModeTypeErrorFunction final : public InternalFunction { >-private: >- StrictModeTypeErrorFunction(VM& vm, Structure* structure, const String& message) >- : InternalFunction(vm, structure, callThrowTypeError, constructThrowTypeError) >- , m_message(message) >- { >- } >- >- static void destroy(JSCell*); >- >-public: >- typedef InternalFunction Base; >- >- template<typename CellType> >- static IsoSubspace* subspaceFor(VM& vm) >- { >- return &vm.strictModeTypeErrorFunctionSpace; >- } >- >- static StrictModeTypeErrorFunction* create(VM& vm, Structure* structure, const String& message) >- { >- StrictModeTypeErrorFunction* function = new (NotNull, allocateCell<StrictModeTypeErrorFunction>(vm.heap)) StrictModeTypeErrorFunction(vm, structure, message); >- function->finishCreation(vm, String()); >- return function; >- } >- >- static EncodedJSValue JSC_HOST_CALL constructThrowTypeError(ExecState* exec) >- { >- VM& vm = exec->vm(); >- auto scope = DECLARE_THROW_SCOPE(vm); >- throwTypeError(exec, scope, static_cast<StrictModeTypeErrorFunction*>(exec->jsCallee())->m_message); >- return JSValue::encode(jsNull()); >- } >- >- static EncodedJSValue JSC_HOST_CALL callThrowTypeError(ExecState* exec) >- { >- VM& vm = exec->vm(); >- auto scope = DECLARE_THROW_SCOPE(vm); >- throwTypeError(exec, scope, static_cast<StrictModeTypeErrorFunction*>(exec->jsCallee())->m_message); >- return JSValue::encode(jsNull()); >- } >- >- DECLARE_INFO; >- >- static Structure* createStructure(VM& vm, JSGlobalObject* globalObject, JSValue prototype) >- { >- return Structure::create(vm, globalObject, prototype, TypeInfo(InternalFunctionType, StructureFlags), info()); >- } >- >-private: >- String m_message; >-}; >- > } // namespace JSC > > namespace WTF { >diff --git a/Source/JavaScriptCore/runtime/VM.cpp b/Source/JavaScriptCore/runtime/VM.cpp >index 7da563a0f5aadedcd1dfafa663321bb6b5d8deb5..97f1aa9fcebaf90fe71e1fd14ed4b2a496d77815 100644 >--- a/Source/JavaScriptCore/runtime/VM.cpp >+++ b/Source/JavaScriptCore/runtime/VM.cpp >@@ -319,7 +319,6 @@ VM::VM(VMType vmType, HeapType heapType) > , propertyTableSpace ISO_SUBSPACE_INIT(heap, destructibleCellHeapCellType.get(), PropertyTable) > , proxyRevokeSpace ISO_SUBSPACE_INIT(heap, destructibleObjectHeapCellType.get(), ProxyRevoke) > , regExpConstructorSpace ISO_SUBSPACE_INIT(heap, destructibleObjectHeapCellType.get(), RegExpConstructor) >- , strictModeTypeErrorFunctionSpace ISO_SUBSPACE_INIT(heap, destructibleObjectHeapCellType.get(), StrictModeTypeErrorFunction) > , structureRareDataSpace ISO_SUBSPACE_INIT(heap, destructibleCellHeapCellType.get(), StructureRareData) > , structureSpace ISO_SUBSPACE_INIT(heap, destructibleCellHeapCellType.get(), Structure) > , weakSetSpace ISO_SUBSPACE_INIT(heap, destructibleObjectHeapCellType.get(), JSWeakSet) >diff --git a/Source/JavaScriptCore/runtime/VM.h b/Source/JavaScriptCore/runtime/VM.h >index 79f4d3b93c52ed5c6b695806a181e2139bbbc838..7c68fc5bc9aa1fa7c3aadccfced688f3a9a26e41 100644 >--- a/Source/JavaScriptCore/runtime/VM.h >+++ b/Source/JavaScriptCore/runtime/VM.h >@@ -394,7 +394,6 @@ class VM : public ThreadSafeRefCounted<VM>, public DoublyLinkedListNode<VM> { > IsoSubspace propertyTableSpace; > IsoSubspace proxyRevokeSpace; > IsoSubspace regExpConstructorSpace; >- IsoSubspace strictModeTypeErrorFunctionSpace; > IsoSubspace structureRareDataSpace; > IsoSubspace structureSpace; > IsoSubspace weakSetSpace;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193662
: 359712