Attachment 359663 Details for Bug 193630 – Patch

[patch] Patch

bug-193630-20190120195814.patch (text/plain), 1.54 KB, created by Michael Catanzaro on 2019-01-20 17:58:15 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2019-01-20 17:58:15 PST

Size: 1.54 KB

patch

obsolete

>Subversion Revision: 240217
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index fe491f6d70d72a5b4392fdad5bc1f6f6314863b1..56cd9d942a826593a871073e5ec1cdad8cb20fd2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        REGRESSION(r240174): Wrong preprocessor guards in RenderImage::paintAreaElementFocusRing
>+        https://bugs.webkit.org/show_bug.cgi?id=193630
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        r240174 inadvertently disabled this function on non-Apple platforms.
>+
>+        This fixes layout test fast/images/image-map-outline-in-positioned-container.html.
>+
>+        * rendering/RenderImage.cpp:
>+        (WebCore::RenderImage::paintAreaElementFocusRing):
>+
> 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Unreviewed, rolling out r238275.
>diff --git a/Source/WebCore/rendering/RenderImage.cpp b/Source/WebCore/rendering/RenderImage.cpp
>index 183a9341948cb2df06c8d3bbbb346255754fb157..5162ac3db861356c1b93271b79630c6cc4f570ea 100644
>--- a/Source/WebCore/rendering/RenderImage.cpp
>+++ b/Source/WebCore/rendering/RenderImage.cpp
>@@ -550,7 +550,7 @@ void RenderImage::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
>     
> void RenderImage::paintAreaElementFocusRing(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
> {
>-#if ENABLE(FULL_KEYBOARD_ACCESS)
>+#if !PLATFORM(IOS_FAMILY) || ENABLE(FULL_KEYBOARD_ACCESS)
>     if (document().printing() || !frame().selection().isFocusedAndActive())
>         return;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193630: 359663