Attachment 359600 Details for Bug 193609 – Patch

[patch] Patch

bug-193609-20190119012052.patch (text/plain), 1.58 KB, created by Yusuke Suzuki on 2019-01-19 01:20:52 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-01-19 01:20:52 PST

Size: 1.58 KB

patch

obsolete

>Subversion Revision: 240200
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 19a250df1e8669b8ab2a7fafd36f316209b112f9..3d01c20daf5287717f099069d4c7457ea21377fa 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-19  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
>+
>+        [JSC] Reorder JSSegmentedVariableObject member for preparation of JSGlobalObject memory reduction
>+        https://bugs.webkit.org/show_bug.cgi?id=193609
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Basically, we should order the members in large => small order not to add paddings.
>+
>+        * runtime/JSSegmentedVariableObject.h:
>+
> 2019-01-18  Keith Miller  <keith_miller@apple.com>
> 
>         JSScript API should only take ascii files.
>diff --git a/Source/JavaScriptCore/runtime/JSSegmentedVariableObject.h b/Source/JavaScriptCore/runtime/JSSegmentedVariableObject.h
>index ae30db768dd44a222d52831ee91faf69c89cd207..cb5fe372ae22fbe10fba8a650f84cef59a24a511 100644
>--- a/Source/JavaScriptCore/runtime/JSSegmentedVariableObject.h
>+++ b/Source/JavaScriptCore/runtime/JSSegmentedVariableObject.h
>@@ -107,9 +107,9 @@ class JSSegmentedVariableObject : public JSSymbolTableObject {
>     
> private:
>     SegmentedVector<WriteBarrier<Unknown>, 16> m_variables;
>+    PoisonedClassInfoPtr m_classInfo;
>     ConcurrentJSLock m_lock;
>     bool m_alreadyDestroyed { false }; // We use these assertions to check that we aren't doing ancient hacks that result in this being destroyed more than once.
>-    PoisonedClassInfoPtr m_classInfo;
> };
> 
> } // namespace JSC

Actions: View | Formatted Diff | Diff

Attachments on bug 193609: 359600