Attachment 359553 Details for Bug 193600 – Patch

[patch] Patch

bug-193600-20190118162929.patch (text/plain), 4.05 KB, created by Sihui Liu on 2019-01-18 16:29:30 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2019-01-18 16:29:30 PST

Size: 4.05 KB

patch

obsolete

>Subversion Revision: 240112
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index e856254f6b5005505f8a1dd3c3c961e87901d7c1..669ef8dfd28c7ad75c9bd3023016bbc3bf29187a 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-01-18  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Layout test storage/indexeddb/open-during-transaction-private.html is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=193600
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make sure the second request is finished before the third one so that test ends properly.
>+
>+        * storage/indexeddb/open-during-transaction-expected.txt:
>+        * storage/indexeddb/open-during-transaction-private-expected.txt:
>+        * storage/indexeddb/resources/open-during-transaction.js:
>+        (tryOpens.openreq3.onsuccess):
>+        (tryOpens.openreq2.onsuccess):
>+        (tryOpens):
>+
> 2019-01-16  Alicia Boya GarcÃa  <aboya@igalia.com>
> 
>         Unreviewed GTK and WPE test gardening.
>diff --git a/LayoutTests/storage/indexeddb/open-during-transaction-expected.txt b/LayoutTests/storage/indexeddb/open-during-transaction-expected.txt
>index f195b5b70805e7c7e578e9b0705f7117441c1cdf..c925160618e856e91caa6c13d8dd772bf9c18242 100644
>--- a/LayoutTests/storage/indexeddb/open-during-transaction-expected.txt
>+++ b/LayoutTests/storage/indexeddb/open-during-transaction-expected.txt
>@@ -17,14 +17,12 @@ the transaction is kept alive with a series of puts until opens are complete
> 
> trying to open the same database
> openreq2 = indexedDB.open(dbname)
>-
>-trying to open a different database
>-openreq3 = indexedDB.open(dbname + '2')
>-
> openreq2.onsuccess
> PASS state is "starting"
> state = 'open2complete'
> 
>+trying to open a different database
>+openreq3 = indexedDB.open(dbname + '2')
> openreq3.onsuccess
> PASS state is "open2complete"
> state = 'open3complete'
>diff --git a/LayoutTests/storage/indexeddb/open-during-transaction-private-expected.txt b/LayoutTests/storage/indexeddb/open-during-transaction-private-expected.txt
>index f195b5b70805e7c7e578e9b0705f7117441c1cdf..c925160618e856e91caa6c13d8dd772bf9c18242 100644
>--- a/LayoutTests/storage/indexeddb/open-during-transaction-private-expected.txt
>+++ b/LayoutTests/storage/indexeddb/open-during-transaction-private-expected.txt
>@@ -17,14 +17,12 @@ the transaction is kept alive with a series of puts until opens are complete
> 
> trying to open the same database
> openreq2 = indexedDB.open(dbname)
>-
>-trying to open a different database
>-openreq3 = indexedDB.open(dbname + '2')
>-
> openreq2.onsuccess
> PASS state is "starting"
> state = 'open2complete'
> 
>+trying to open a different database
>+openreq3 = indexedDB.open(dbname + '2')
> openreq3.onsuccess
> PASS state is "open2complete"
> state = 'open3complete'
>diff --git a/LayoutTests/storage/indexeddb/resources/open-during-transaction.js b/LayoutTests/storage/indexeddb/resources/open-during-transaction.js
>index 19a56a75ccf2c0424e5bdecac715ef95f02a6583..2b6b1dec7747cee8080841fdd273dc1d70f98006 100644
>--- a/LayoutTests/storage/indexeddb/resources/open-during-transaction.js
>+++ b/LayoutTests/storage/indexeddb/resources/open-during-transaction.js
>@@ -55,17 +55,15 @@ function tryOpens()
>         shouldBeEqualToString("state", "starting");
>         evalAndLog("state = 'open2complete'");
>         debug("");
>-    };
>-    debug("");
> 
>-    debug("trying to open a different database");
>-    evalAndLog("openreq3 = indexedDB.open(dbname + '2')");
>-    openreq3.onerror = unexpectedErrorCallback;
>-    openreq3.onsuccess = function (e) {
>-        debug("openreq3.onsuccess");
>-        shouldBeEqualToString("state", "open2complete");
>-        evalAndLog("state = 'open3complete'");
>-        debug("");
>+        debug("trying to open a different database");
>+        evalAndLog("openreq3 = indexedDB.open(dbname + '2')");
>+        openreq3.onerror = unexpectedErrorCallback;
>+        openreq3.onsuccess = function (e) {
>+            debug("openreq3.onsuccess");
>+            shouldBeEqualToString("state", "open2complete");
>+            evalAndLog("state = 'open3complete'");
>+            debug("");
>+        };
>     };
>-    debug("");
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 193600: 359553