Attachment 359547 Details for Bug 193595 – Proposed patch

[patch] Proposed patch

build-webkit-rename-unit-to-api-test.patch (text/plain), 3.86 KB, created by Aakash Jain on 2019-01-18 15:22:18 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-18 15:22:18 PST

Size: 3.86 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240181)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-18  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [build.webkit.org] api tests failures are incorrectly named as unit test failures
>+        https://bugs.webkit.org/show_bug.cgi?id=193595
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
>+        * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
>+        * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
>+
> 2019-01-18  Chris Dumez  <cdumez@apple.com>
> 
>         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
>Index: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py
>===================================================================
>--- Tools/BuildSlaveSupport/build.webkit.org-config/factories.py	(revision 240181)
>+++ Tools/BuildSlaveSupport/build.webkit.org-config/factories.py	(working copy)
>@@ -90,7 +90,7 @@ class TestFactory(Factory):
>             self.addStep(self.LayoutTestClass())
> 
>         if platform.startswith('win') or platform.startswith('mac') or platform.startswith('ios-simulator'):
>-            self.addStep(RunUnitTests())
>+            self.addStep(RunAPITests())
>         self.addStep(RunPythonTests())
>         self.addStep(RunPerlTests())
>         self.addStep(RunBindingsTests())
>Index: Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/build.webkit.org-config/steps.py	(revision 240181)
>+++ Tools/BuildSlaveSupport/build.webkit.org-config/steps.py	(working copy)
>@@ -503,12 +503,12 @@ class RunDashboardTests(RunWebKitTests):
>         return RunWebKitTests.start(self)
> 
> 
>-class RunUnitTests(TestWithFailureCount):
>+class RunAPITests(TestWithFailureCount):
>     name = "run-api-tests"
>-    description = ["unit tests running"]
>-    descriptionDone = ["unit-tests"]
>+    description = ["api tests running"]
>+    descriptionDone = ["api-tests"]
>     command = ["python", "./Tools/Scripts/run-api-tests", "--no-build", WithProperties("--%(configuration)s"), "--verbose"]
>-    failedTestsFormatString = "%d unit test%s failed or timed out"
>+    failedTestsFormatString = "%d api test%s failed or timed out"
> 
>     def start(self):
>         appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
>Index: Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py	(revision 240181)
>+++ Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py	(working copy)
>@@ -260,20 +260,20 @@ class Run32bitJSCTestsTest(unittest.Test
>         self.assertResults(SUCCESS, ['webkit-32bit-jsc-test'], 0,  '    0 failures found.')
> 
> 
>-class RunUnitTestsTest(unittest.TestCase):
>+class RunAPITestsTest(unittest.TestCase):
>     def assertFailures(self, expected_failure_count, stdio):
>         if expected_failure_count:
>             rc = 1
>             expected_results = FAILURE
>             plural_suffix = "" if expected_failure_count == 1 else "s"
>-            expected_text = '%d unit test%s failed or timed out' % (expected_failure_count, plural_suffix)
>+            expected_text = '%d api test%s failed or timed out' % (expected_failure_count, plural_suffix)
>         else:
>             rc = 0
>             expected_results = SUCCESS
>             expected_text = 'run-api-tests'
> 
>         cmd = StubRemoteCommand(rc, stdio)
>-        step = RunUnitTests()
>+        step = RunAPITests()
>         step.commandComplete(cmd)
>         actual_results = step.evaluateCommand(cmd)
>         actual_failure_count = step.failedTestCount

Actions: View | Formatted Diff | Diff

Attachments on bug 193595: 359547