Attachment 359533 Details for Bug 193589 – Patch

[patch] Patch

bug-193589-20190118134003.patch (text/plain), 2.06 KB, created by Devin Rousso on 2019-01-18 13:40:04 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-01-18 13:40:04 PST

Size: 2.06 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 5e4ac456aa4a0239640041fbe5bf3df117108023..d84073903087407e2a02fa0d8eaad594d489c040 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-18  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'resource.finished')
>+        https://bugs.webkit.org/show_bug.cgi?id=193589
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/NetworkTableContentView.js:
>+        (WI.NetworkTableContentView.prototype.get supportsSave):
>+        (WI.NetworkTableContentView.prototype._HARResources):
>+
> 2019-01-16  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: Fix TreeOutline TypeError:â this._indexesForSubtree is not a function
>diff --git a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>index 57ec8af3f10a4097c60000c467c53dc5cff39132..3c718282f9889a87f752d86d3ec36622c734043e 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>@@ -224,7 +224,7 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
> 
>     get supportsSave()
>     {
>-        return this._filteredEntries.some((entry) => entry.resource.finished);
>+        return this._canExportHAR();
>     }
> 
>     get saveData()
>@@ -1890,6 +1890,11 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
>         let resources = this._filteredEntries.map((x) => x.resource);
>         const supportedHARSchemes = new Set(["http", "https", "ws", "wss"]);
>         return resources.filter((resource) => {
>+            if (!resource) {
>+                // DOM node entries are also added to `_filteredEntries`.
>+                return false;
>+            }
>+
>             if (!resource.finished)
>                 return false;
>             if (!resource.requestSentDate)

Actions: View | Formatted Diff | Diff

Attachments on bug 193589: 359533