Attachment 359500 Details for Bug 193371 – Patch

[patch] Patch

bug-193371-20190118095558.patch (text/plain), 8.62 KB, created by Eric Liang on 2019-01-18 09:55:59 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Liang

Created: 2019-01-18 09:55:59 PST

Size: 8.62 KB

patch

obsolete

>Subversion Revision: 240018
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index e00d3145c707897b692f580be3269ab6d189ed48..0628915906be090384cd47b09adbfba453b4eca9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-17  Eric Liang  <ericliang@apple.com>
>+
>+        AXSelected attribute on RadioButton should not be settable.
>+        https://bugs.webkit.org/show_bug.cgi?id=193371
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Test: accessibility/set-selected-editable.html
>+
>+        * accessibility/AccessibilityNodeObject.cpp:
>+        (WebCore::AccessibilityNodeObject::canSetSelectedAttribute const):
>+
> 2019-01-15  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         [WHLSL] Implement the loop checker
>diff --git a/Source/WebCore/accessibility/AccessibilityNodeObject.cpp b/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
>index c2a7ace9066751f9ebdd2e4190d5a157ca188ea4..8b7d6e6ffa15545cda1b45c6177c267916713b0d 100644
>--- a/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
>+++ b/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
>@@ -2232,7 +2232,6 @@ bool AccessibilityNodeObject::canSetSelectedAttribute() const
>     switch (roleValue()) {
>     case AccessibilityRole::Cell:
>     case AccessibilityRole::GridCell:
>-    case AccessibilityRole::RadioButton:
>     case AccessibilityRole::RowHeader:
>     case AccessibilityRole::Row:
>     case AccessibilityRole::TabList:
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index fb54e06ef6722b0c063e0bef3bbeca099124e05a..8b5d24f28cb36fc684a2c52f08c1ccff4fea6db0 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-17  Eric Liang  <ericliang@apple.com>
>+
>+        AXSelected attribute on RadioButton should not be settable.
>+        https://bugs.webkit.org/show_bug.cgi?id=193371
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This change make RadioButton AXSelected attribute no-settable. If this attribute is not writable, then the trackpad should work correctly.
>+
>+        * accessibility/set-selected-editable-expected.txt: Added.
>+        * accessibility/set-selected-editable.html: Added.
>+
> 2019-01-15  Chris Dumez  <cdumez@apple.com>
> 
>         Unreviewed, rolling out r239993, r239995, r239997, and
>diff --git a/LayoutTests/accessibility/set-selected-editable-expected.txt b/LayoutTests/accessibility/set-selected-editable-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..709a7786b3b626d64a48d318c55fbe3ea3dc995f
>--- /dev/null
>+++ b/LayoutTests/accessibility/set-selected-editable-expected.txt
>@@ -0,0 +1,51 @@
>+X
>+X
>+X
>+X
>+X
>+X
>+X
>+X
>+X
>+X
>+X
>+tree item
>+Crust
>+Item one
>+Item four
>+Item five
>+  
>+This tests that the accessibility Selected attribute can be settable only on certain elements.
>+
>+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
>+
>+
>+PASS axElement.isAttributeSettable('AXSelected') is false
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is false
>+PASS axElement.isAttributeSettable('AXSelected') is false
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is false
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is false
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is false
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is true
>+PASS axElement.isAttributeSettable('AXSelected') is false
>+PASS axElement.isAttributeSettable('AXSelected') is false
>+PASS axElement.isAttributeSettable('AXSelected') is false
>+
>diff --git a/LayoutTests/accessibility/set-selected-editable.html b/LayoutTests/accessibility/set-selected-editable.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..e805e81044da0e970adc2392ddf622e4ef7615f5
>--- /dev/null
>+++ b/LayoutTests/accessibility/set-selected-editable.html
>@@ -0,0 +1,72 @@
>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
>+<html>
>+<head>
>+<meta charset="utf-8">
>+<script src="../resources/js-test-pre.js"></script>
>+</head>
>+<body id="body">
>+
>+<div id="test0" role="table" selected-expected-value="false">
>+  <div id="test1" role="row" selected-expected-value="true">
>+    <div id="test2" role="columnheader" selected-expected-value="false">X</div>
>+    <div id="test3" role="columnheader" selected-expected-value="false">X</div>
>+  </div>
>+  <div id="test4" role="row" selected-expected-value="true">
>+    <div id="test5" role="rowheader" selected-expected-value="true">X</div>
>+    <div id="test6" role="cell" selected-expected-value="true">X</div>
>+  </div>
>+</div>
>+
>+<div id="test7" role="grid" selected-expected-value="false">
>+  <div id="test8" role="row" selected-expected-value="true">
>+    <div id="test9" role="columnheader" selected-expected-value="false">X</div>
>+    <div role="columnheader">X</div>
>+  </div>
>+  <div id="test10" role="row" selected-expected-value="true">
>+    <div id="test11" role="rowheader" selected-expected-value="true">X</div>
>+    <div id="test12" role="gridcell" selected-expected-value="true">X</div>
>+  </div>
>+</div>
>+
>+<div id="test13" role="treegrid" selected-expected-value="true">
>+  <div id="test14" role="row" selected-expected-value="true">
>+    <div id="test15" role="columnheader" selected-expected-value="false">X</div>
>+    <div id="test16" role="gridcell" selected-expected-value="true">X</div>
>+    <div id="test17" role="rowheader" selected-expected-value="true">X</div>
>+  </div>
>+</div>
>+
>+<ul id="test18" role="tree" selected-expected-value="true">
>+    <li id="test19" role="treeitem" selected-expected-value="true">tree item</li>
>+</ul>
>+
>+<ul id="test20" role="tablist" selected-expected-value="true">
>+<li id="test21" role="tab" tabindex="-1" selected-expected-value="true">Crust</li>
>+</ul>
>+
>+<div id="test22" role="menuitemradio" aria-checked="true" selected-expected-value="true">Item one</div>
>+<div id="test23" role="menuitemcheckbox" aria-checked="false" selected-expected-value="true">Item four</div>
>+<div id="test24" role="menuitem" selected-expected-value="true">Item five</div>
>+
>+<input id="test25" type="radio" selected-expected-value="false">
>+<input id="test26" type="checkbox" selected-expected-value="false"/>
>+<input id="test27" type="text" role="combobox" selected-expected-value="false">
>+
>+<p id="description"></p>
>+<div id="console"></div>
>+
>+<script>
>+    description("This tests that the accessibility Selected attribute can be settable only on certain elements.");
>+
>+    if (window.accessibilityController) {
>+          for (var i = 0; i <= 27; i++) {
>+              var axElement = accessibilityController.accessibleElementById("test" + i);
>+              shouldBe("axElement.isAttributeSettable('AXSelected')", document.getElementById("test" + i).getAttribute("selected-expected-value"));
>+          }
>+    }
>+
>+</script>
>+
>+<script src="../../resources/js-test-post.js"></script>
>+</body>
>+</html>
>diff --git a/LayoutTests/platform/win/TestExpectations b/LayoutTests/platform/win/TestExpectations
>index ed0c2980015060090d6a9bc03a422faf5bef51bc..00bdfd0b3c8e56c73cfe4e5c52bd4230cab7a32c 100644
>--- a/LayoutTests/platform/win/TestExpectations
>+++ b/LayoutTests/platform/win/TestExpectations
>@@ -1479,6 +1479,8 @@ webkit.org/b/140798 [ Release ] accessibility/aria-switch-checked.html [ Skip ]
> webkit.org/b/140798 [ Debug ] accessibility/aria-switch-checked.html [ Skip ]
> webkit.org/b/140798 [ Release ] accessibility/aria-switch-text.html [ Skip ]
> webkit.org/b/140798 [ Debug ] accessibility/aria-switch-text.html [ Skip ]
>+webkit.org/b/193371 [ Release ] accessibility/set-selected-editable.html [ Skip ]
>+webkit.org/b/193371 [ Debug ] accessibility/set-selected-editable.html [ Skip ]
> 
> # The following timeouts are caused by the same problem: [ Failure ]
> webkit.org/b/126066 accessibility/loading-iframe-updates-axtree.html [ Skip ]

Actions: View | Formatted Diff | Diff

Attachments on bug 193371: 359438 | 359439 | 359445 | 359500 | 359516