Attachment 359407 Details for Bug 193551 – Patch

[patch] Patch

bug-193551-20190117125827.patch (text/plain), 1.68 KB, created by Alex Christensen on 2019-01-17 12:58:28 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-01-17 12:58:28 PST

Size: 1.68 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240124)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-01-17  Alex Christensen  <achristensen@webkit.org>
>+
>+        Fix string concatenation API test after r239920
>+        https://bugs.webkit.org/show_bug.cgi?id=193551
>+        <rdar://problem/47359304>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
>+        (TestWebKitAPI::TEST):
>+        Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
>+        in WebKit's build configuration like it apparently is on Linux.
>+
> 2019-01-17  Jer Noble  <jer.noble@apple.com>
> 
>         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
>Index: Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp
>===================================================================
>--- Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp	(revision 240116)
>+++ Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp	(working copy)
>@@ -82,7 +82,7 @@ TEST(WTF, StringConcatenate_Unsigned)
>     EXPECT_EQ("hello 0 world", makeString("hello ", 0u , " world"));
> 
>     EXPECT_EQ("hello 42 world", makeString("hello ", static_cast<unsigned char>(42) , " world"));
>-#if PLATFORM(WIN) || U_ICU_VERSION_MAJOR_NUM >= 59
>+#if PLATFORM(WIN) || (U_ICU_VERSION_MAJOR_NUM >= 59 && !PLATFORM(COCOA))
>     EXPECT_EQ("hello 42 world", makeString("hello ", static_cast<unsigned short>(42) , " world"));
> #else
>     EXPECT_EQ("hello * world", makeString("hello ", static_cast<unsigned short>(42) , " world")); // Treated as a character.

Flags:

youennf: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193551: 359407