Attachment 359403 Details for Bug 193547 – Proposed patch

[patch] Proposed patch

ews-build-bugid-None.patch (text/plain), 1.82 KB, created by Aakash Jain on 2019-01-17 12:17:20 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-17 12:17:20 PST

Size: 1.82 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240122)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-17  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] validate-patch should handle the case when bug_id is None
>+        https://bugs.webkit.org/show_bug.cgi?id=193547
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
>+        (ValidatePatch.start): If bug_id is set as None in build propeties, fetch it from the patch.
>+
> 2019-01-17  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][BFC] An element with transform is a containing block for positioned descendants.
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 240122)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -303,6 +303,10 @@ class ValidatePatch(buildstep.BuildStep)
>         return 0
> 
>     def _is_bug_closed(self, bug_id):
>+        if not bug_id:
>+            self._addToLog('stdio', 'Skipping bug status validation since bug id is None.\n')
>+            return -1
>+
>         bug_json = self.get_bug_json(bug_id)
>         if not bug_json or not bug_json.get('status'):
>             self._addToLog('stdio', 'Unable to fetch bug {}.\n'.format(bug_id))
>@@ -327,7 +331,7 @@ class ValidatePatch(buildstep.BuildStep)
>             self.finished(FAILURE)
>             return None
> 
>-        bug_id = self.getProperty('bug_id', self.get_bug_id_from_patch(patch_id))
>+        bug_id = self.getProperty('bug_id', '') or self.get_bug_id_from_patch(patch_id)
> 
>         bug_closed = self._is_bug_closed(bug_id)
>         if bug_closed == 1:

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193547: 359403