WebKit Bugzilla
Attachment 359387 Details for
Bug 193182
: [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-193182-20190117101502.patch (text/plain), 1.97 KB, created by
Wenson Hsieh
on 2019-01-17 10:15:03 PST
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Wenson Hsieh
Created:
2019-01-17 10:15:03 PST
Size:
1.97 KB
patch
obsolete
>Subversion Revision: 240102 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 36447b9d34cbc4e14eb64391bdb63b159576dd64..52f13ce11e18ca33b2f4831d8a24d6053ef283f0 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,22 @@ >+2019-01-17 Wenson Hsieh <wenson_hsieh@apple.com> >+ >+ [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out >+ https://bugs.webkit.org/show_bug.cgi?id=193182 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html) >+ long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture >+ recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html. >+ >+ To fix this, tweak the test runner to make it safe for tests to end while touching the web view without >+ preventing later tests from recognizing gestures. >+ >+ * WebKitTestRunner/ios/TestControllerIOS.mm: >+ (WTR::TestController::platformResetStateToConsistentValues): >+ >+ Cancel all touches in the UIApplication when resetting to a consistent state between tests. >+ > 2019-01-17 Wenson Hsieh <wenson_hsieh@apple.com> > > [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas >diff --git a/Tools/WebKitTestRunner/ios/TestControllerIOS.mm b/Tools/WebKitTestRunner/ios/TestControllerIOS.mm >index 610c97fd4fe5677d2595b27426e90255bc5e7034..58b8aeb9df3e508680776c467922fc598c102630 100644 >--- a/Tools/WebKitTestRunner/ios/TestControllerIOS.mm >+++ b/Tools/WebKitTestRunner/ios/TestControllerIOS.mm >@@ -115,6 +115,7 @@ void TestController::platformResetStateToConsistentValues(const TestOptions& opt > { > cocoaResetStateToConsistentValues(options); > >+ [[UIApplication sharedApplication] _cancelAllTouches]; > [[UIDevice currentDevice] setOrientation:UIDeviceOrientationPortrait animated:NO]; > > m_inputModeSwizzlers.clear();
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193182
:
359387
|
359753
|
359859