Attachment 359343 Details for Bug 193524 – Patch

[patch] Patch

bug-193524-20190116190246.patch (text/plain), 19.12 KB, created by Simon Fraser (smfr) on 2019-01-16 19:02:46 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2019-01-16 19:02:46 PST

Size: 19.12 KB

patch

obsolete

>Subversion Revision: 240047
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 33b90d656238f39cc6f48d837922a81c501534c0..66acdc5be9b25ee7806cc50e628f110a6b69e2a7 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,42 @@
>+2019-01-16  Simon Fraser  <simon.fraser@apple.com>
>+
>+        Stub out scrolling tree classes for overflow scrolling nodes on macOS
>+        https://bugs.webkit.org/show_bug.cgi?id=193524
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add an empty implementation of ScrollingTreeOverflowScrollingNodeMac for macOS. Change
>+        ScrollingTreeMac::createScrollingTreeNode() to create these nodes.
>+        
>+        Minor refactor of RenderLayerCompositor::useCoordinatedScrollingForLayer() code to ask
>+        the scrolling coordinator if it can coordinate scrolling for this layer; no behavior
>+        change for existing code paths.
>+
>+        * SourcesCocoa.txt:
>+        * WebCore.xcodeproj/project.pbxproj:
>+        * page/scrolling/ScrollingCoordinator.cpp:
>+        (WebCore::ScrollingCoordinator::coordinatesScrollingForOverflowLayer const):
>+        * page/scrolling/ScrollingCoordinator.h:
>+        * page/scrolling/mac/ScrollingStateFrameScrollingNodeMac.mm:
>+        * page/scrolling/mac/ScrollingTreeMac.cpp:
>+        (ScrollingTreeMac::createScrollingTreeNode):
>+        * page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h: Copied from Source/WebCore/page/scrolling/mac/ScrollingStateFrameScrollingNodeMac.mm.
>+        * page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm: Added.
>+        (WebCore::ScrollingTreeOverflowScrollingNodeMac::create):
>+        (WebCore::ScrollingTreeOverflowScrollingNodeMac::ScrollingTreeOverflowScrollingNodeMac):
>+        (WebCore::ScrollingTreeOverflowScrollingNodeMac::~ScrollingTreeOverflowScrollingNodeMac):
>+        (WebCore::ScrollingTreeOverflowScrollingNodeMac::commitStateBeforeChildren):
>+        (WebCore::ScrollingTreeOverflowScrollingNodeMac::commitStateAfterChildren):
>+        (WebCore::ScrollingTreeOverflowScrollingNodeMac::updateLayersAfterAncestorChange):
>+        (WebCore::ScrollingTreeOverflowScrollingNodeMac::scrollPosition const):
>+        (WebCore::ScrollingTreeOverflowScrollingNodeMac::setScrollLayerPosition):
>+        (WebCore::ScrollingTreeOverflowScrollingNodeMac::updateLayersAfterDelegatedScroll):
>+        * rendering/RenderLayer.cpp:
>+        (WebCore::RenderLayer::usesAsyncScrolling const):
>+        * rendering/RenderLayerCompositor.cpp:
>+        (WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer const):
>+        * rendering/RenderLayerCompositor.h:
>+
> 2019-01-15  Simon Fraser  <simon.fraser@apple.com>
> 
>         Make didCommitChangesForLayer() explicitly about the platform layer changing because of tile/non-tile swapping
>diff --git a/Source/WebCore/SourcesCocoa.txt b/Source/WebCore/SourcesCocoa.txt
>index 2005c9a92e16fe7171f7a7bbdf4b7bbdfda5b9e7..90cefd2fe12ea38caa423bd90dc9bc710b792fb1 100644
>--- a/Source/WebCore/SourcesCocoa.txt
>+++ b/Source/WebCore/SourcesCocoa.txt
>@@ -157,6 +157,7 @@ page/scrolling/mac/ScrollingStateFrameScrollingNodeMac.mm
> page/scrolling/mac/ScrollingThreadMac.mm
> page/scrolling/mac/ScrollingTreeFixedNode.mm
> page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm
>+page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm
> page/scrolling/mac/ScrollingTreeMac.cpp
> page/scrolling/mac/ScrollingTreeStickyNode.mm
> 
>diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>index ce49fdf3e41997091612168be35d51b8cbcf3b6e..a2f10acfe3ad2965a5158c98d4798bb8b47f2803 100644
>--- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>@@ -5783,6 +5783,8 @@
> 		0FB88909167D2FA10010CDA5 /* ScrollingTreeStickyNode.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollingTreeStickyNode.mm; sourceTree = "<group>"; };
> 		0FB8890C167D30160010CDA5 /* ScrollingStateStickyNode.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ScrollingStateStickyNode.cpp; sourceTree = "<group>"; };
> 		0FB8890D167D30160010CDA5 /* ScrollingStateStickyNode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ScrollingStateStickyNode.h; sourceTree = "<group>"; };
>+		0FC05168219B5EBE0031C39E /* ScrollingTreeOverflowScrollingNodeMac.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollingTreeOverflowScrollingNodeMac.mm; sourceTree = "<group>"; };
>+		0FC0516A219B5EBE0031C39E /* ScrollingTreeOverflowScrollingNodeMac.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ScrollingTreeOverflowScrollingNodeMac.h; sourceTree = "<group>"; };
> 		0FC4E407187F82E10045882C /* ScrollingCoordinatorIOS.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ScrollingCoordinatorIOS.h; sourceTree = "<group>"; };
> 		0FC4E408187F82E10045882C /* ScrollingCoordinatorIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollingCoordinatorIOS.mm; sourceTree = "<group>"; };
> 		0FC4E409187F82E10045882C /* ScrollingTreeIOS.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ScrollingTreeIOS.cpp; sourceTree = "<group>"; };
>@@ -16922,6 +16924,8 @@
> 				93C4A4141629DF5A00C3EB6E /* ScrollingTreeFrameScrollingNodeMac.mm */,
> 				0FE5806119327A6200DE32EB /* ScrollingTreeMac.cpp */,
> 				0FE5806219327A6200DE32EB /* ScrollingTreeMac.h */,
>+				0FC0516A219B5EBE0031C39E /* ScrollingTreeOverflowScrollingNodeMac.h */,
>+				0FC05168219B5EBE0031C39E /* ScrollingTreeOverflowScrollingNodeMac.mm */,
> 				0FB88908167D2FA10010CDA5 /* ScrollingTreeStickyNode.h */,
> 				0FB88909167D2FA10010CDA5 /* ScrollingTreeStickyNode.mm */,
> 			);
>diff --git a/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp b/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
>index cb8738396a3a58ef4520ee548cf831eb415471b8..908c22149ca13a1388112251bb3bebd49d778e19 100644
>--- a/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
>+++ b/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
>@@ -87,6 +87,14 @@ bool ScrollingCoordinator::coordinatesScrollingForFrameView(const FrameView& fra
>     return renderView->usesCompositing();
> }
> 
>+bool ScrollingCoordinator::coordinatesScrollingForOverflowLayer(const RenderLayer& layer) const
>+{
>+    ASSERT(isMainThread());
>+    ASSERT(m_page);
>+
>+    return layer.hasCompositedScrollableOverflow();
>+}
>+
> EventTrackingRegions ScrollingCoordinator::absoluteEventTrackingRegionsForFrame(const Frame& frame) const
> {
>     auto* renderView = frame.contentRenderer();
>diff --git a/Source/WebCore/page/scrolling/ScrollingCoordinator.h b/Source/WebCore/page/scrolling/ScrollingCoordinator.h
>index 614b67055748a1d0c58aa4105aa89960d6901e56..7cb884571c3af3e2a9b6d7192ad61a83c6f92015 100644
>--- a/Source/WebCore/page/scrolling/ScrollingCoordinator.h
>+++ b/Source/WebCore/page/scrolling/ScrollingCoordinator.h
>@@ -77,6 +77,7 @@ class FrameView;
> class GraphicsLayer;
> class Page;
> class Region;
>+class RenderLayer;
> class ScrollableArea;
> class ViewportConstraints;
> 
>@@ -131,7 +132,10 @@ public:
>     virtual bool isRemoteScrollingCoordinator() const { return false; }
> 
>     // Return whether this scrolling coordinator handles scrolling for the given frame view.
>-    virtual bool coordinatesScrollingForFrameView(const FrameView&) const;
>+    WEBCORE_EXPORT virtual bool coordinatesScrollingForFrameView(const FrameView&) const;
>+
>+    // Return whether this scrolling coordinator handles scrolling for the given overflow scroll layer.
>+    WEBCORE_EXPORT virtual bool coordinatesScrollingForOverflowLayer(const RenderLayer&) const;
> 
>     // Should be called whenever the given frame view has been laid out.
>     virtual void frameViewLayoutUpdated(FrameView&) { }
>diff --git a/Source/WebCore/page/scrolling/mac/ScrollingStateFrameScrollingNodeMac.mm b/Source/WebCore/page/scrolling/mac/ScrollingStateFrameScrollingNodeMac.mm
>index 2fddf235f9aaea2421a25046bb5af8d63f1be16e..8830f129f5cfb4283005d375ddae7e40704cbe37 100644
>--- a/Source/WebCore/page/scrolling/mac/ScrollingStateFrameScrollingNodeMac.mm
>+++ b/Source/WebCore/page/scrolling/mac/ScrollingStateFrameScrollingNodeMac.mm
>@@ -26,15 +26,15 @@
> #include "config.h"
> #include "ScrollingStateFrameScrollingNode.h"
> 
>+#if ENABLE(ASYNC_SCROLLING) && PLATFORM(MAC)
>+
> #include "GraphicsLayer.h"
> #include "Scrollbar.h"
> #include "ScrollbarThemeMac.h"
> #include "ScrollingStateTree.h"
> 
>-#if ENABLE(ASYNC_SCROLLING) && PLATFORM(MAC)
>-
> namespace WebCore {
>-    
>+
> void ScrollingStateFrameScrollingNode::setScrollerImpsFromScrollbars(Scrollbar* verticalScrollbar, Scrollbar* horizontalScrollbar)
> {
>     ScrollbarTheme& scrollbarTheme = ScrollbarTheme::theme();
>diff --git a/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.cpp b/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.cpp
>index 78e6ee3cd639d6366d77c5c0701940218431729b..6010e3a0f3d4a03a3f4721efa65d345e8af6bcda 100644
>--- a/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.cpp
>+++ b/Source/WebCore/page/scrolling/mac/ScrollingTreeMac.cpp
>@@ -28,6 +28,7 @@
> 
> #include "ScrollingTreeFixedNode.h"
> #include "ScrollingTreeFrameScrollingNodeMac.h"
>+#include "ScrollingTreeOverflowScrollingNodeMac.h"
> #include "ScrollingTreeStickyNode.h"
> 
> #if ENABLE(ASYNC_SCROLLING) && PLATFORM(MAC)
>@@ -51,7 +52,7 @@ Ref<ScrollingTreeNode> ScrollingTreeMac::createScrollingTreeNode(ScrollingNodeTy
>     case ScrollingNodeType::Subframe:
>         return ScrollingTreeFrameScrollingNodeMac::create(*this, nodeType, nodeID);
>     case ScrollingNodeType::Overflow:
>-        ASSERT_NOT_REACHED();
>+        return ScrollingTreeOverflowScrollingNodeMac::create(*this, nodeID);
>         break;
>     case ScrollingNodeType::Fixed:
>         return ScrollingTreeFixedNode::create(*this, nodeID);
>diff --git a/Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h b/Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h
>new file mode 100644
>index 0000000000000000000000000000000000000000..f1eedbedef3db06259ad16c5f707e5d2b3538962
>--- /dev/null
>+++ b/Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h
>@@ -0,0 +1,59 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#pragma once
>+
>+#if ENABLE(ASYNC_SCROLLING) && PLATFORM(MAC)
>+
>+#include "ScrollingTreeOverflowScrollingNode.h"
>+
>+namespace WebCore {
>+
>+class ScrollingTreeOverflowScrollingNodeMac : public WebCore::ScrollingTreeOverflowScrollingNode {
>+public:
>+    static Ref<ScrollingTreeOverflowScrollingNodeMac> create(WebCore::ScrollingTree&, WebCore::ScrollingNodeID);
>+    virtual ~ScrollingTreeOverflowScrollingNodeMac();
>+
>+private:
>+    ScrollingTreeOverflowScrollingNodeMac(WebCore::ScrollingTree&, WebCore::ScrollingNodeID);
>+
>+    void commitStateBeforeChildren(const WebCore::ScrollingStateNode&) override;
>+    void commitStateAfterChildren(const WebCore::ScrollingStateNode&) override;
>+    
>+    WebCore::FloatPoint scrollPosition() const override;
>+
>+    void setScrollLayerPosition(const WebCore::FloatPoint&, const WebCore::FloatRect& layoutViewport) override;
>+
>+    void updateLayersAfterViewportChange(const WebCore::FloatRect&, double) override { }
>+    void updateLayersAfterDelegatedScroll(const WebCore::FloatPoint& scrollPosition) override;
>+
>+    void updateLayersAfterAncestorChange(const WebCore::ScrollingTreeNode& changedNode, const WebCore::FloatRect& fixedPositionRect, const WebCore::FloatSize& cumulativeDelta) override;
>+
>+    void handleWheelEvent(const WebCore::PlatformWheelEvent&) override { }
>+};
>+
>+} // namespace WebKit
>+
>+#endif // ENABLE(ASYNC_SCROLLING) && PLATFORM(MAC)
>diff --git a/Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm b/Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm
>new file mode 100644
>index 0000000000000000000000000000000000000000..56dbc51030dbcdbd5742571568f332648ca666ec
>--- /dev/null
>+++ b/Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm
>@@ -0,0 +1,81 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#import "config.h"
>+#import "ScrollingTreeOverflowScrollingNodeMac.h"
>+
>+#if ENABLE(ASYNC_SCROLLING) && PLATFORM(MAC)
>+
>+namespace WebCore {
>+
>+Ref<ScrollingTreeOverflowScrollingNodeMac> ScrollingTreeOverflowScrollingNodeMac::create(WebCore::ScrollingTree& scrollingTree, WebCore::ScrollingNodeID nodeID)
>+{
>+    return adoptRef(*new ScrollingTreeOverflowScrollingNodeMac(scrollingTree, nodeID));
>+}
>+
>+ScrollingTreeOverflowScrollingNodeMac::ScrollingTreeOverflowScrollingNodeMac(WebCore::ScrollingTree& scrollingTree, WebCore::ScrollingNodeID nodeID)
>+    : ScrollingTreeOverflowScrollingNode(scrollingTree, nodeID)
>+{
>+}
>+
>+ScrollingTreeOverflowScrollingNodeMac::~ScrollingTreeOverflowScrollingNodeMac()
>+{
>+}
>+
>+void ScrollingTreeOverflowScrollingNodeMac::commitStateBeforeChildren(const WebCore::ScrollingStateNode& stateNode)
>+{
>+    ScrollingTreeOverflowScrollingNode::commitStateBeforeChildren(stateNode);
>+}
>+
>+void ScrollingTreeOverflowScrollingNodeMac::commitStateAfterChildren(const ScrollingStateNode& stateNode)
>+{
>+    ScrollingTreeOverflowScrollingNode::commitStateAfterChildren(stateNode);
>+}
>+
>+void ScrollingTreeOverflowScrollingNodeMac::updateLayersAfterAncestorChange(const ScrollingTreeNode& changedNode, const FloatRect& fixedPositionRect, const FloatSize& cumulativeDelta)
>+{
>+    UNUSED_PARAM(changedNode);
>+    UNUSED_PARAM(fixedPositionRect);
>+    UNUSED_PARAM(cumulativeDelta);
>+}
>+
>+FloatPoint ScrollingTreeOverflowScrollingNodeMac::scrollPosition() const
>+{
>+    return { };
>+}
>+
>+void ScrollingTreeOverflowScrollingNodeMac::setScrollLayerPosition(const FloatPoint& scrollPosition, const FloatRect&)
>+{
>+    UNUSED_PARAM(scrollPosition);
>+}
>+
>+void ScrollingTreeOverflowScrollingNodeMac::updateLayersAfterDelegatedScroll(const FloatPoint& scrollPosition)
>+{
>+    UNUSED_PARAM(scrollPosition);
>+}
>+
>+} // namespace WebCore
>+
>+#endif // ENABLE(ASYNC_SCROLLING) && PLATFORM(MAC)
>diff --git a/Source/WebCore/rendering/RenderLayer.cpp b/Source/WebCore/rendering/RenderLayer.cpp
>index 6c2a423b6776fc990f0a7e0f340661bccd0f237d..072e937bf789e210906d20d4c9d3c3ff85887018 100644
>--- a/Source/WebCore/rendering/RenderLayer.cpp
>+++ b/Source/WebCore/rendering/RenderLayer.cpp
>@@ -2223,7 +2223,7 @@ bool RenderLayer::usesCompositedScrolling() const
> // FIXME: this is only valid after we've made layers.
> bool RenderLayer::usesAsyncScrolling() const
> {
>-    return usesCompositedScrolling();
>+    return compositor().useCoordinatedScrollingForLayer(*this);
> }
> 
> static inline int adjustedScrollDelta(int beginningDelta)
>diff --git a/Source/WebCore/rendering/RenderLayerCompositor.cpp b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>index 29f75fca2a90287fc3f4176224342ab310fc004b..d08d691e26916a1ca7bf3833245eeb56ce1cc8ee 100644
>--- a/Source/WebCore/rendering/RenderLayerCompositor.cpp
>+++ b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>@@ -2837,10 +2837,10 @@ bool RenderLayerCompositor::useCoordinatedScrollingForLayer(const RenderLayer& l
>     if (layer.isRenderViewLayer() && hasCoordinatedScrolling())
>         return true;
> 
>-#if PLATFORM(IOS_FAMILY)
>-    return layer.hasCompositedScrollableOverflow();
>-#endif
>-    return false; // FIXME: Fix for composited scrolling on other platforms.
>+    if (auto* scrollingCoordinator = this->scrollingCoordinator())
>+        return scrollingCoordinator->coordinatesScrollingForOverflowLayer(layer);
>+    
>+    return false;
> }
> 
> bool RenderLayerCompositor::isRunningTransformAnimation(RenderLayerModelObject& renderer) const
>diff --git a/Source/WebCore/rendering/RenderLayerCompositor.h b/Source/WebCore/rendering/RenderLayerCompositor.h
>index 9c9074dd2e6ea085ece350898469ff5c2f4a0acb..4a2c3be424dcfe8b6f38d754885a31a08924360a 100644
>--- a/Source/WebCore/rendering/RenderLayerCompositor.h
>+++ b/Source/WebCore/rendering/RenderLayerCompositor.h
>@@ -324,6 +324,8 @@ public:
>     void updateScrollCoordinatedStatus(RenderLayer&, OptionSet<ScrollingNodeChangeFlags>);
>     void removeFromScrollCoordinatedLayers(RenderLayer&);
> 
>+    bool useCoordinatedScrollingForLayer(const RenderLayer&) const;
>+
>     void willRemoveScrollingLayerWithBacking(RenderLayer&, RenderLayerBacking&);
>     void didAddScrollingLayer(RenderLayer&);
> 
>@@ -492,7 +494,6 @@ private:
> 
>     // True if the FrameView uses a ScrollingCoordinator.
>     bool hasCoordinatedScrolling() const;
>-    bool useCoordinatedScrollingForLayer(const RenderLayer&) const;
> 
>     // FIXME: make the coordinated/async terminology consistent.
>     bool isAsyncScrollableStickyLayer(const RenderLayer&, const RenderLayer** enclosingAcceleratedOverflowLayer = nullptr) const;

Actions: View | Formatted Diff | Diff

Attachments on bug 193524: 359343