Attachment 359325 Details for Bug 193508 – Patch

[patch] Patch

bug-193508-20190116154820.patch (text/plain), 1.67 KB, created by Alex Christensen on 2019-01-16 15:48:21 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-01-16 15:48:21 PST

Size: 1.67 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 240087)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-16  Alex Christensen  <achristensen@webkit.org>
>+
>+        sendBeacon to previously-unvisited https domain always fails
>+        https://bugs.webkit.org/show_bug.cgi?id=193508
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * NetworkProcess/PingLoad.cpp:
>+        (WebKit::PingLoad::didReceiveChallenge):
>+        If a ping load is doing a TLS handshake, continue if the server has good certificates.
>+
> 2019-01-16  Alex Christensen  <achristensen@webkit.org>
> 
>         Revert r239938
>Index: Source/WebKit/NetworkProcess/PingLoad.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/PingLoad.cpp	(revision 240043)
>+++ Source/WebKit/NetworkProcess/PingLoad.cpp	(working copy)
>@@ -117,10 +117,14 @@ void PingLoad::willPerformHTTPRedirectio
>     });
> }
> 
>-void PingLoad::didReceiveChallenge(AuthenticationChallenge&&, ChallengeCompletionHandler&& completionHandler)
>+void PingLoad::didReceiveChallenge(AuthenticationChallenge&& challenge, ChallengeCompletionHandler&& completionHandler)
> {
>     RELEASE_LOG_IF_ALLOWED("didReceiveChallenge");
>     auto weakThis = makeWeakPtr(*this);
>+    if (challenge.protectionSpace().authenticationScheme() == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested) {
>+        completionHandler(AuthenticationChallengeDisposition::PerformDefaultHandling, { });
>+        return;
>+    }
>     completionHandler(AuthenticationChallengeDisposition::Cancel, { });
>     if (!weakThis)
>         return;

Flags:

ggaren: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193508: 359325