Attachment 359285 Details for Bug 193501 – Patch

[patch] Patch

bug-193501-20190116114231.patch (text/plain), 1.77 KB, created by Matt Baker on 2019-01-16 11:42:32 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2019-01-16 11:42:32 PST

Size: 1.77 KB

patch

obsolete

>Subversion Revision: 240043
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 0c8431784b013cd83ab12f4818e2545e92e6bf2c..52eb3229afee0e5be2edc037b985daebe49612f9 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-01-16  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: Fix TreeOutline TypeError:â this._indexesForSubtree is not a function
>+        https://bugs.webkit.org/show_bug.cgi?id=193501
>+        <rdar://problem/47323967>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/TreeOutline.js:
>+        (WI.TreeOutline.prototype.removeChildAtIndex):
>+
> 2019-01-15  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Audit: create new IDL type for exposing special functionality in test context
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>index 9a0183e7d6cae2e0171700227c27bec544dd868d..a47e60b89af6e0def5b868a6447905f5ab29ef9d 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js
>@@ -323,14 +323,15 @@ WI.TreeOutline = class TreeOutline extends WI.Object
>                 parent.select(true, false);
>         }
> 
>+        let removedIndexes = null;
>+
>         let treeOutline = child.treeOutline;
>         if (treeOutline) {
>             treeOutline._forgetTreeElement(child);
>             treeOutline._forgetChildrenRecursive(child);
>+            removedIndexes = treeOutline._indexesForSubtree(child);
>         }
> 
>-        let removedIndexes = this._indexesForSubtree(child);
>-
>         if (child.previousSibling)
>             child.previousSibling.nextSibling = child.nextSibling;
>         if (child.nextSibling)

Actions: View | Formatted Diff | Diff

Attachments on bug 193501: 359285