Attachment 359268 Details for Bug 193495 – Patch

[patch] Patch

bug-193495-20190116090807.patch (text/plain), 2.84 KB, created by zalan on 2019-01-16 09:08:23 PST

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2019-01-16 09:08:23 PST

Size: 2.84 KB

patch

obsolete

>Subversion Revision: 240036
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 95528835fe8f226b4998c6a2f98c94ddb6afc3e8..70f3af5c3686610506ca0a7db3e94ee7b454ef95 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-16  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC][BFC] Inflow non-replaced used width value should not be negative.
>+        https://bugs.webkit.org/show_bug.cgi?id=193495
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * layout/blockformatting/BlockFormattingContextGeometry.cpp:
>+        (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
>+
> 2019-01-16  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
>diff --git a/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp b/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp
>index f9cc7d39a7b69014e83989e1c8850353a3dbd96a..a7864701734d26df04239a0e7d1455db8e8a447e 100644
>--- a/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp
>+++ b/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp
>@@ -194,7 +194,7 @@ WidthAndMargin BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin
> 
>         ASSERT(width);
> 
>-        return WidthAndMargin { contentWidth(), usedHorizontalMargin, computedHorizontalMargin };
>+        return WidthAndMargin { std::max(LayoutUnit { }, contentWidth()), usedHorizontalMargin, computedHorizontalMargin };
>     };
> 
>     auto widthAndMargin = compute();
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index f53ced5c023838432fceca20b4135a040214e159..ae439ba0fd6cf9e6af7d3a452ad83263e0e86a3d 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-01-16  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC][BFC] Inflow non-replaced used width should not be negative.
>+        https://bugs.webkit.org/show_bug.cgi?id=193495
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * LayoutReloaded/misc/LFC-passing-tests.txt:
>+
> 2019-01-16  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
>diff --git a/Tools/LayoutReloaded/misc/LFC-passing-tests.txt b/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
>index 494526438b2b6202212c32d089aefb65dcc41ed2..4695f112c9cde690222b8c6b1ad5b20a8d72a086 100644
>--- a/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
>+++ b/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
>@@ -83,6 +83,8 @@ fast/block/block-only/non-auto-top-bottom-height-with-margins.html
> fast/block/block-only/non-auto-top-bottom-height-with-auto-margins.html
> fast/block/basic/002.html
> fast/block/basic/003.html
>+fast/block/basic/004.html
>+fast/block/basic/005.html
> fast/block/basic/006.html
> fast/block/basic/007.html
> fast/block/basic/008.html

Actions: View | Formatted Diff | Diff

Attachments on bug 193495: 359268 | 359328