Attachment 359245 Details for Bug 193430 – Patch

[patch] Patch

bug-193430-20190115191007.patch (text/plain), 19.83 KB, created by Myles C. Maxfield on 2019-01-15 19:10:08 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2019-01-15 19:10:08 PST

Size: 19.83 KB

patch

obsolete

>Subversion Revision: 240024
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 3c69442d1802a73ae00b2b2f1c33375fe02fef3d..c972da96a6ff5aa3ff408211f1231e3b79d063d1 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,29 @@
>+2019-01-15  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [WHLSL] Add the literal type checker
>+        https://bugs.webkit.org/show_bug.cgi?id=193430
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is a translation of https://github.com/gpuweb/WHLSL/blob/master/Source/LiteralTypeChecker.mjs into C++.
>+
>+        No new tests because it isn't hooked up yet. Not enough of the compiler exists to have any meaningful sort
>+        of test. When enough of the compiler is present, I'll port the reference implementation's test suite.
>+
>+        * Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h:
>+        (WebCore::WHLSL::AST::FloatLiteralType::value const):
>+        * Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h:
>+        (WebCore::WHLSL::AST::IntegerLiteralType::value const):
>+        * Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h:
>+        (WebCore::WHLSL::AST::UnsignedIntegerLiteralType::value const):
>+        * Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp: Added.
>+        (WebCore::WHLSL::getNativeTypeDeclaration):
>+        (WebCore::WHLSL::LiteralTypeChecker::visit):
>+        (WebCore::WHLSL::checkLiteralTypes):
>+        * Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h.
>+        * Sources.txt:
>+        * WebCore.xcodeproj/project.pbxproj:
>+
> 2019-01-15  Megan Gardner  <megan_gardner@apple.com>
> 
>         Add Reveal support in iOSMac
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h
>index bc9f037099de0d810bed89ab12a451e5b3b08366..64743c4aef449e93aba0100e89c4bdd16e2459e9 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h
>@@ -53,6 +53,8 @@ public:
> 
>     bool isFloatLiteralType() const override { return true; }
> 
>+    float value() const { return m_value; }
>+
>     TypeReference& preferredType() { return m_preferredType; }
> 
>     bool canResolve(const Type&) const override;
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h
>index 55617b6ba9eafbe185cdfe1ecf0eb3145dcaebcd..3d06b1df5f8d988fad87ac92564f8cf1f008bb96 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h
>@@ -53,6 +53,8 @@ public:
> 
>     bool isIntegerLiteralType() const override { return true; }
> 
>+    int value() const { return m_value; }
>+
>     TypeReference& preferredType() { return m_preferredType; }
> 
>     bool canResolve(const Type&) const override;
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h
>index 95fbff6b9029f05ab524f730f9543f4d1e702707..ebc3106bcabf270e1108b89e4da9d487e3ce99ea 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h
>@@ -53,6 +53,8 @@ public:
> 
>     bool isUnsignedIntegerLiteralType() const override { return true; }
> 
>+    unsigned value() const { return m_value; }
>+
>     TypeReference& preferredType() { return m_preferredType; }
> 
>     bool canResolve(const Type&) const override;
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp
>new file mode 100644
>index 0000000000000000000000000000000000000000..b4739534dcde5fb3dc222ba36f76dd0a07e5f4e5
>--- /dev/null
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp
>@@ -0,0 +1,104 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#include "config.h"
>+#include "WHLSLLiteralTypeChecker.h"
>+
>+#if ENABLE(WEBGPU)
>+
>+#include "WHLSLIntegerLiteralType.h"
>+#include "WHLSLNativeTypeDeclaration.h"
>+#include "WHLSLNullLiteralType.h"
>+#include "WHLSLProgram.h"
>+#include "WHLSLTypeReference.h"
>+#include "WHLSLVisitor.h"
>+
>+namespace WebCore {
>+
>+namespace WHLSL {
>+
>+#if !ASSERT_DISABLED
>+static AST::NativeTypeDeclaration* getNativeTypeDeclaration(AST::ResolvableType& resolvableType)
>+{
>+    if (!resolvableType.resolvedType())
>+        return nullptr;
>+    if (!is<AST::TypeReference>(*resolvableType.resolvedType()))
>+        return nullptr;
>+    auto& typeReference = downcast<AST::TypeReference>(*resolvableType.resolvedType());
>+    ASSERT(typeReference.resolvedType());
>+    if (!is<AST::NativeTypeDeclaration>(*typeReference.resolvedType()))
>+        return nullptr;
>+    return &downcast<AST::NativeTypeDeclaration>(*typeReference.resolvedType());
>+}
>+
>+class LiteralTypeChecker : public Visitor {
>+public:
>+    LiteralTypeChecker() = default;
>+
>+    virtual ~LiteralTypeChecker() = default;
>+
>+private:
>+    void visit(AST::FloatLiteralType& floatLiteralType) override
>+    {
>+        auto* nativeTypeDeclaration = getNativeTypeDeclaration(floatLiteralType);
>+        ASSERT(nativeTypeDeclaration);
>+        ASSERT(nativeTypeDeclaration->canRepresentInteger()(floatLiteralType.value()));
>+    }
>+
>+    void visit(AST::IntegerLiteralType& integerLiteralType) override
>+    {
>+        auto* nativeTypeDeclaration = getNativeTypeDeclaration(integerLiteralType);
>+        ASSERT(nativeTypeDeclaration);
>+        ASSERT(nativeTypeDeclaration->canRepresentInteger()(integerLiteralType.value()));
>+    }
>+
>+    void visit(AST::UnsignedIntegerLiteralType& unsignedIntegerLiteralType) override
>+    {
>+        auto* nativeTypeDeclaration = getNativeTypeDeclaration(unsignedIntegerLiteralType);
>+        ASSERT(nativeTypeDeclaration);
>+        ASSERT(nativeTypeDeclaration->canRepresentInteger()(unsignedIntegerLiteralType.value()));
>+    }
>+
>+    void visit(AST::NullLiteralType& nullLiteralType) override
>+    {
>+        ASSERT(nullLiteralType.resolvedType());
>+    }
>+};
>+#endif
>+
>+void checkLiteralTypes(Program& program)
>+{
>+#if ASSERT_DISABLED
>+    UNUSED_PARAM(program);
>+#else
>+    LiteralTypeChecker().Visitor::visit(program);
>+#endif
>+}
>+
>+}
>+
>+}
>+
>+#endif
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.h b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.h
>new file mode 100644
>index 0000000000000000000000000000000000000000..71a46de2cfc59cd32c71c960928faccb5329711c
>--- /dev/null
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.h
>@@ -0,0 +1,42 @@
>+/*
>+ * Copyright (C) 2019 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#pragma once
>+
>+#if ENABLE(WEBGPU)
>+
>+namespace WebCore {
>+
>+namespace WHLSL {
>+
>+class Program;
>+
>+void checkLiteralTypes(Program&);
>+
>+}
>+
>+}
>+
>+#endif
>diff --git a/Source/WebCore/Sources.txt b/Source/WebCore/Sources.txt
>index 446a806a878a51ab987bb7d1c37328cd8ee97c14..2d79170ad8f09236da42acbcdc7c0645e90b0567 100644
>--- a/Source/WebCore/Sources.txt
>+++ b/Source/WebCore/Sources.txt
>@@ -322,6 +322,7 @@ Modules/webgpu/WHLSL/WHLSLNameContext.cpp
> Modules/webgpu/WHLSL/WHLSLNameResolver.cpp
> Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp
> Modules/webgpu/WHLSL/WHLSLVisitor.cpp
>+Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp
> Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp
> Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.cpp
> Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp
>diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>index b96fa2dec41e49e314142d0b64522ba3c7924c6a..8e5f53d4591725da611978148a9dec4fa1f6690b 100644
>--- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>@@ -2585,9 +2585,9 @@
> 		91278D5E21DEDAD600B57184 /* PageAuditAgent.h in Headers */ = {isa = PBXBuildFile; fileRef = 91278D5C21DEDAD500B57184 /* PageAuditAgent.h */; };
> 		91278D6221DEDAF000B57184 /* WorkerAuditAgent.h in Headers */ = {isa = PBXBuildFile; fileRef = 91278D6021DEDAF000B57184 /* WorkerAuditAgent.h */; };
> 		9175CE5C21E281ED00DF2C27 /* InspectorAuditDOMObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5821E281EC00DF2C27 /* InspectorAuditDOMObject.h */; };
>-		9175CE5C21E281ED00DF2C28 /* JSInspectorAuditDOMObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5821E281EC00DF2C28 /* InspectorAuditDOMObject.h */; };
>+		9175CE5C21E281ED00DF2C28 /* InspectorAuditDOMObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5821E281EC00DF2C28 /* InspectorAuditDOMObject.h */; };
> 		9175CE5E21E281ED00DF2C27 /* InspectorAuditAccessibilityObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5A21E281ED00DF2C27 /* InspectorAuditAccessibilityObject.h */; };
>-		9175CE5E21E281ED00DF2C28 /* JSInspectorAuditAccessibilityObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5A21E281ED00DF2C28 /* InspectorAuditAccessibilityObject.h */; };
>+		9175CE5E21E281ED00DF2C28 /* InspectorAuditAccessibilityObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 9175CE5A21E281ED00DF2C28 /* InspectorAuditAccessibilityObject.h */; };
> 		91B8F0B521953D65000C2B00 /* CertificateInfoBase.h in Headers */ = {isa = PBXBuildFile; fileRef = 91B8F0B321953D65000C2B00 /* CertificateInfoBase.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		91B952241F58A58F00931DC2 /* RecordingSwizzleTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = 91B952221F58A58000931DC2 /* RecordingSwizzleTypes.h */; };
> 		91C9F2F91AE3BEB00095B61C /* AXTextStateChangeIntent.h in Headers */ = {isa = PBXBuildFile; fileRef = 91C9F2F81AE3BE240095B61C /* AXTextStateChangeIntent.h */; settings = {ATTRIBUTES = (Private, ); }; };
>@@ -6429,6 +6429,8 @@
> 		1C904DF90BA9D2C80081E9D0 /* Version.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = Version.xcconfig; sourceTree = "<group>"; };
> 		1C9AE5CF21EDA27E0069D5F2 /* WHLSLLoopChecker.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WHLSLLoopChecker.cpp; sourceTree = "<group>"; };
> 		1C9AE5D021EDA27E0069D5F2 /* WHLSLLoopChecker.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLLoopChecker.h; sourceTree = "<group>"; };
>+		1CA0C2EA21EED6F500A11860 /* WHLSLLiteralTypeChecker.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLLiteralTypeChecker.h; sourceTree = "<group>"; };
>+		1CA0C2EC21EED6F600A11860 /* WHLSLLiteralTypeChecker.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WHLSLLiteralTypeChecker.cpp; sourceTree = "<group>"; };
> 		1CA19E030DC255950065A994 /* EventLoopMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = EventLoopMac.mm; sourceTree = "<group>"; };
> 		1CA19E150DC255CA0065A994 /* EventLoop.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EventLoop.h; sourceTree = "<group>"; };
> 		1CAF347E0A6C405200ABE06E /* WebScriptObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebScriptObject.h; sourceTree = "<group>"; };
>@@ -10394,13 +10396,13 @@
> 		91278D5F21DEDAEF00B57184 /* WorkerAuditAgent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WorkerAuditAgent.cpp; sourceTree = "<group>"; };
> 		91278D6021DEDAF000B57184 /* WorkerAuditAgent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WorkerAuditAgent.h; sourceTree = "<group>"; };
> 		9175CE5721E281EB00DF2C27 /* InspectorAuditDOMObject.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorAuditDOMObject.cpp; sourceTree = "<group>"; };
>-		9175CE5721E281EB00DF2C28 /* JSInspectorAuditDOMObject.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorAuditDOMObject.cpp; sourceTree = "<group>"; };
>+		9175CE5721E281EB00DF2C28 /* InspectorAuditDOMObject.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorAuditDOMObject.cpp; sourceTree = "<group>"; };
> 		9175CE5821E281EC00DF2C27 /* InspectorAuditDOMObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorAuditDOMObject.h; sourceTree = "<group>"; };
>-		9175CE5821E281EC00DF2C28 /* JSInspectorAuditDOMObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorAuditDOMObject.h; sourceTree = "<group>"; };
>+		9175CE5821E281EC00DF2C28 /* InspectorAuditDOMObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorAuditDOMObject.h; sourceTree = "<group>"; };
> 		9175CE5921E281EC00DF2C27 /* InspectorAuditAccessibilityObject.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorAuditAccessibilityObject.cpp; sourceTree = "<group>"; };
>-		9175CE5921E281EC00DF2C28 /* JSInspectorAuditAccessibilityObject.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorAuditAccessibilityObject.cpp; sourceTree = "<group>"; };
>+		9175CE5921E281EC00DF2C28 /* InspectorAuditAccessibilityObject.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorAuditAccessibilityObject.cpp; sourceTree = "<group>"; };
> 		9175CE5A21E281ED00DF2C27 /* InspectorAuditAccessibilityObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorAuditAccessibilityObject.h; sourceTree = "<group>"; };
>-		9175CE5A21E281ED00DF2C28 /* JSInspectorAuditAccessibilityObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorAuditAccessibilityObject.h; sourceTree = "<group>"; };
>+		9175CE5A21E281ED00DF2C28 /* InspectorAuditAccessibilityObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorAuditAccessibilityObject.h; sourceTree = "<group>"; };
> 		91B8F0B321953D65000C2B00 /* CertificateInfoBase.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CertificateInfoBase.h; sourceTree = "<group>"; };
> 		91B952221F58A58000931DC2 /* RecordingSwizzleTypes.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RecordingSwizzleTypes.h; sourceTree = "<group>"; };
> 		91C9F2F81AE3BE240095B61C /* AXTextStateChangeIntent.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AXTextStateChangeIntent.h; sourceTree = "<group>"; };
>@@ -16937,12 +16939,12 @@
> 			isa = PBXGroup;
> 			children = (
> 				A584FE2518637DAB00843B10 /* CommandLineAPIModuleSource.h */,
>+				9175CE5921E281EC00DF2C28 /* InspectorAuditAccessibilityObject.cpp */,
>+				9175CE5A21E281ED00DF2C28 /* InspectorAuditAccessibilityObject.h */,
>+				9175CE5721E281EB00DF2C28 /* InspectorAuditDOMObject.cpp */,
>+				9175CE5821E281EC00DF2C28 /* InspectorAuditDOMObject.h */,
> 				A584FE391864E2D800843B10 /* JSCommandLineAPIHost.cpp */,
> 				A584FE3A1864E2D800843B10 /* JSCommandLineAPIHost.h */,
>-				9175CE5921E281EC00DF2C28 /* JSInspectorAuditAccessibilityObject.cpp */,
>-				9175CE5A21E281ED00DF2C28 /* JSInspectorAuditAccessibilityObject.h */,
>-				9175CE5721E281EB00DF2C28 /* JSInspectorAuditDOMObject.cpp */,
>-				9175CE5821E281EC00DF2C28 /* JSInspectorAuditDOMObject.h */,
> 				7A0E771C10C00DB100A0276E /* JSInspectorFrontendHost.cpp */,
> 				7A0E771D10C00DB100A0276E /* JSInspectorFrontendHost.h */,
> 			);
>@@ -25462,6 +25464,8 @@
> 				C234A9B621E92CC0003C984D /* WHLSLIntrinsics.h */,
> 				C210E91121B4BD1000B7F83D /* WHLSLLexer.cpp */,
> 				C210E91221B4BD1000B7F83D /* WHLSLLexer.h */,
>+				1CA0C2EC21EED6F600A11860 /* WHLSLLiteralTypeChecker.cpp */,
>+				1CA0C2EA21EED6F500A11860 /* WHLSLLiteralTypeChecker.h */,
> 				1C9AE5CF21EDA27E0069D5F2 /* WHLSLLoopChecker.cpp */,
> 				1C9AE5D021EDA27E0069D5F2 /* WHLSLLoopChecker.h */,
> 				C234A98D21E88884003C984D /* WHLSLNameContext.cpp */,
>@@ -29552,7 +29556,9 @@
> 				93309DF2099E64920056E581 /* InsertTextCommand.h in Headers */,
> 				A5B81CA71FAA44620037D1E6 /* InspectorApplicationCacheAgent.h in Headers */,
> 				9175CE5E21E281ED00DF2C27 /* InspectorAuditAccessibilityObject.h in Headers */,
>+				9175CE5E21E281ED00DF2C28 /* InspectorAuditAccessibilityObject.h in Headers */,
> 				9175CE5C21E281ED00DF2C27 /* InspectorAuditDOMObject.h in Headers */,
>+				9175CE5C21E281ED00DF2C28 /* InspectorAuditDOMObject.h in Headers */,
> 				6A22E8701F10418600F546C3 /* InspectorCanvas.h in Headers */,
> 				A5B81CA81FAA44620037D1E6 /* InspectorCanvasAgent.h in Headers */,
> 				1C81B95C0E97330800266E07 /* InspectorClient.h in Headers */,
>@@ -29985,8 +29991,6 @@
> 				A77979290D6B9E64003851B9 /* JSImageData.h in Headers */,
> 				7C193C011F5E11050088F3E6 /* JSImageSmoothingQuality.h in Headers */,
> 				A86629D309DA2B48009633A6 /* JSInputEvent.h in Headers */,
>-				9175CE5E21E281ED00DF2C28 /* JSInspectorAuditAccessibilityObject.h in Headers */,
>-				9175CE5C21E281ED00DF2C28 /* JSInspectorAuditDOMObject.h in Headers */,
> 				7A0E771F10C00DB100A0276E /* JSInspectorFrontendHost.h in Headers */,
> 				0F4710E61DB700C7002DCEC3 /* JSIntersectionObserver.h in Headers */,
> 				0F8B45761DC41DBA00443C3F /* JSIntersectionObserverCallback.h in Headers */,

Flags:

dino: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193430: 359126 | 359216 | 359245