Attachment 359229 Details for Bug 193472 – Patch

[patch] Patch

bug-193472-20190115171540.patch (text/plain), 1.89 KB, created by Jonathan Bedard on 2019-01-15 17:15:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-01-15 17:15:40 PST

Size: 1.89 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240019)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-01-15  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: Support boolean simctl isAvailable
>+        https://bugs.webkit.org/show_bug.cgi?id=193472
>+        <rdar://problem/47296150>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/xcode/simulated_device.py:
>+        (SimulatedDeviceManager._create_runtimes):
>+        (SimulatedDeviceManager._create_device_with_runtime):
>+
> 2019-01-15  Chris Dumez  <cdumez@apple.com>
> 
>         Unreviewed, rolling out r239993, r239995, r239997, and
>Index: Tools/Scripts/webkitpy/xcode/simulated_device.py
>===================================================================
>--- Tools/Scripts/webkitpy/xcode/simulated_device.py	(revision 240009)
>+++ Tools/Scripts/webkitpy/xcode/simulated_device.py	(working copy)
>@@ -77,7 +77,7 @@ class SimulatedDeviceManager(object):
>     def _create_runtimes(runtimes):
>         result = []
>         for runtime in runtimes:
>-            if runtime.get('availability') != '(available)' and runtime.get('isAvailable') != 'YES':
>+            if runtime.get('availability') != '(available)' and runtime.get('isAvailable') != 'YES' and runtime.get('isAvailable') != True:
>                 continue
>             try:
>                 result.append(SimulatedDeviceManager.Runtime(runtime))
>@@ -87,7 +87,7 @@ class SimulatedDeviceManager(object):
> 
>     @staticmethod
>     def _create_device_with_runtime(host, runtime, device_info):
>-        if device_info.get('availability') != '(available)' and device_info.get('isAvailable') != 'YES':
>+        if device_info.get('availability') != '(available)' and device_info.get('isAvailable') != 'YES' and device_info.get('isAvailable') != True:
>             return None
> 
>         # Check existing devices.

Actions: View | Formatted Diff | Diff

Attachments on bug 193472: 359229