Attachment 359222 Details for Bug 193471 – Patch

[patch] Patch

bug-193471-20190115163308.patch (text/plain), 14.71 KB, created by Myles C. Maxfield on 2019-01-15 16:33:08 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2019-01-15 16:33:08 PST

Size: 14.71 KB

patch

obsolete

>Subversion Revision: 240018
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index e00d3145c707897b692f580be3269ab6d189ed48..4eaa3e14d8ac754c9b065cf237c19b93c5bc91f7 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,38 @@
>+2019-01-15  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [WHLSL] Add ending namespace comments to make namespace boundaries more clear
>+        https://bugs.webkit.org/show_bug.cgi?id=193471
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch only adds the comments to the files that are too long to fit on a single screen in my editor.
>+
>+        No new tests because there is no behavior change.
>+
>+        * Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLChecker.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h:
>+        * Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLIntrinsics.h:
>+        * Modules/webgpu/WHLSL/WHLSLLexer.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLLexer.h:
>+        * Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLNameContext.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLNameResolver.h:
>+        * Modules/webgpu/WHLSL/WHLSLParser.h:
>+        * Modules/webgpu/WHLSL/WHLSLProgram.h:
>+        * Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLVisitor.cpp:
>+        * Modules/webgpu/WHLSL/WHLSLVisitor.h:
>+
> 2019-01-15  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         [WHLSL] Implement the loop checker
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp
>index 8d5f68f07b6c038fe5ba7bbc82dcecd18c2ebeeb..868bfccee78d01e7a73d1dae1a1b918a6fbde176 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp
>@@ -105,8 +105,8 @@ bool checkDuplicateFunctions(const Program& program)
>     return true;
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp
>index 9f59089467337cdf6b231f0325d374128c3c5a78..7b6ad2c36135d00279921c8288cbf0c4f6225376 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp
>@@ -1472,8 +1472,8 @@ bool check(Program& program)
>     return checker.assignTypes();
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp
>index 5bd54c9b910d1baaf6705184574a1696d41969ce..a18eac38ea3b676ae789be595a3daa813c6f29b6 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp
>@@ -177,8 +177,8 @@ Optional<EntryPointItems> gatherEntryPointItems(const Intrinsics& intrinsics, AS
>     return {{ inputGatherer.takeEntryPointItems(), outputGatherer.takeEntryPointItems() }};
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h
>index 9d4f7dd84457fea60691a65eb3f1d7f3a5489308..20367be3e2953c6bed0e1b7ff4e7849448ebbdff 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h
>@@ -62,8 +62,8 @@ struct EntryPointItems {
> 
> Optional<EntryPointItems> gatherEntryPointItems(const Intrinsics&, AST::FunctionDefinition&);
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLInferTypes.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLInferTypes.cpp
>index 7cbdb6aff2e26dfee6f61f450b786ce14d27267b..0a2c9eb09412b2538ddd5d238ed505c1bac860f3 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLInferTypes.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLInferTypes.cpp
>@@ -239,8 +239,8 @@ bool inferTypesForCall(AST::FunctionDeclaration& possibleFunction, Vector<std::r
>     return true;
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp
>index 47687850b47f5ee4e2649f49ff68060fd6920691..297e34fc55dee9106adedd441f4e3f046cb0a259 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp
>@@ -417,8 +417,8 @@ void Intrinsics::add(AST::NativeTypeDeclaration& nativeTypeDeclaration)
>     addTexture(nativeTypeDeclaration);
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.h b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.h
>index eb2c04556b00f3890abff19fb636361a38901140..5f4aa308f771b6b8bb5c11c2258ccff62cc95130 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLIntrinsics.h
>@@ -146,8 +146,8 @@ private:
>     AST::NativeTypeDeclaration* m_textureDepthCube[WTF_ARRAY_LENGTH(m_depthTextureInnerTypes)];
> };
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp
>index e9aeae7b542238e9836a54807da1f01175b28902..964bc41166968dd5ef6af08b5fff503601a8ca97 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp
>@@ -819,8 +819,8 @@ Optional<unsigned> Lexer::operatorName(unsigned offset) const
>     return WTF::nullopt;
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.h b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.h
>index a418fa1707549834c0b87d271ece90251239ba23..136e9800684db3009f85041fd0b7e60edd26a4d9 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.h
>@@ -276,8 +276,8 @@ template<unsigned length> Optional<unsigned> Lexer::anyCharacter(const char (&st
>     return WTF::nullopt;
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp
>index 7173eebfb6b8db4717c2629b5b2f6f28845140b0..09c22b423ab83c4e258e44f92ff9cf3e42f3eb96 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLLoopChecker.cpp
>@@ -142,8 +142,8 @@ bool findHighZombies(Program& program)
>     return !loopChecker.error();
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameContext.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameContext.cpp
>index ca313068181f45aa7decdb163995bb0384c3c0d1..38214a4d6a0940f9a9fb5107280f3f91eb216bdc 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameContext.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameContext.cpp
>@@ -156,8 +156,8 @@ bool NameContext::exists(String& name)
>         || m_variables.find(name) != m_variables.end();
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp
>index 2e0edef46f4e592abc7a4e910325367f756a0f8a..9c4193140c106a60eb0508b8cf9c85d5e3bcebf7 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.cpp
>@@ -279,8 +279,8 @@ bool resolveNamesInFunctions(Program& program, NameResolver& nameResolver)
>     return true;
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h
>index 65189e2a835b6851e5e0d0aae1ca8aecaf2b37e4..530b39fe127e6bb03d61393a7a955423fe5113b4 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLNameResolver.h
>@@ -71,8 +71,8 @@ private:
> bool resolveNamesInTypes(Program&, NameResolver&);
> bool resolveNamesInFunctions(Program&, NameResolver&);
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
>index 5671c4513ad6ebf353aa92819b921795dcaad293..8736f9ba7e9f1391b900965b20e479c5598482a4 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
>@@ -105,8 +105,8 @@ class Parser {
> 
> };
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLProgram.h b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLProgram.h
>index 81510d33c98925f4984aabed0db41c0387558230..5d4bda1062d274cddf6a33e95fc985d7c116433f 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLProgram.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLProgram.h
>@@ -106,8 +106,8 @@ private:
>     Vector<UniqueRef<AST::NativeTypeDeclaration>> m_nativeTypeDeclarations;
> };
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp
>index e3201d25949e0babcfee5d88aa2b2b14f80d634a..2a6bba615a9a0b7d9ab5bb6c45f7b798995ef6e3 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp
>@@ -101,8 +101,8 @@ bool checkRecursiveTypes(Program& program)
>     return recursiveTypeChecker.error();
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp
>index ea1833d8d9aca4ae3ca0e9cd70283cf39c24436a..572a465109b7efa464fd9b917b7e16253e99c461 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp
>@@ -107,8 +107,8 @@ AST::NamedType* resolveTypeOverloadImpl(Vector<std::reference_wrapper<AST::Named
>     return result;
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp
>index 9d620fa11a7072f86b0e83db333b21db7eca1051..43aab6118cd1bdb163839c0af7f2c8e9b31d9ed7 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp
>@@ -74,8 +74,8 @@ void synthesizeArrayOperatorLength(Program& program)
>     }
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp
>index 85e2b881d9b40a3885e2930cc8cd71bb39d9c206..6112e0ae9b85da3f56c73e801e132bfa3ce4a371 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp
>@@ -126,8 +126,8 @@ void synthesizeConstructors(Program& program)
>     }
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp
>index 83454834f920fd31b384393790e6160ca7c35b73..e26d74f32f2449b00fe4a0635d0b4b7babcc138e 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp
>@@ -77,8 +77,8 @@ void synthesizeEnumerationFunctions(Program& program)
>     }
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp
>index b99dc770b5dfcb40a5605cedfb13443dfddbda9e..30fdd22fb6ff5f529ce063e54ee65603743e8452 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp
>@@ -83,8 +83,8 @@ void synthesizeStructureAccessors(Program& program)
>     }
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp
>index 52d2e8fccb474a90e0e3452d015e5c6b39f405b5..80b4e1c8e40c6e153a4bb7a079595a69a6e65bf1 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp
>@@ -619,8 +619,8 @@ void Visitor::visit(AST::VariableReference&)
> {
> }
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.h b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.h
>index a5e4c96d8a01c231382d06e7a39f61c6b2e3bce3..cc8c86fef71399caba8b1c4f0c39d68c0aeac725 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.h
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.h
>@@ -195,8 +195,8 @@ private:
>     bool m_error { false }; // FIXME: Migrate this to be some sort of descriptive string.
> };
> 
>-}
>+} // namespace WHLSL
> 
>-}
>+} // namespace WebCore
> 
>-#endif
>+#endif // ENABLE(WEBGPU)

Actions: View | Formatted Diff | Diff

Attachments on bug 193471: 359222