Attachment 359207 Details for Bug 193465 – Proposed patch

[patch] Proposed patch

ews-build-author.patch (text/plain), 1.35 KB, created by Aakash Jain on 2019-01-15 14:42:11 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-01-15 14:42:11 PST

Size: 1.35 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 240009)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-01-15  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add patch author information in build
>+        https://bugs.webkit.org/show_bug.cgi?id=193465
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (ValidatePatch._is_patch_obsolete):
>+
> 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 240009)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -280,6 +280,8 @@ class ValidatePatch(buildstep.BuildStep)
>             self._addToLog('stdio', 'Fetched patch id {} does not match with requested patch id {}. Unable to validate.\n'.format(patch_json.get('id'), self.getProperty('patch_id', '')))
>             return -1
> 
>+        patch_author = patch_json.get('creator')
>+        self.addURL('Patch by: {}'.format(patch_author), 'mailto:{}'.format(patch_author))
>         return patch_json.get('is_obsolete')
> 
>     def _is_patch_review_denied(self, patch_id):

Actions: View | Formatted Diff | Diff

Attachments on bug 193465: 359207