Attachment 359190 Details for Bug 193456 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

bail-1.patch (text/plain), 1.29 KB, created by Joseph Pecoraro on 2019-01-15 12:15:23 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2019-01-15 12:15:23 PST

Size: 1.29 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 1319dde179a..e18700f110c 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-01-15  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        [iOS] Attempting to open a Keynote document to iCloud.com from iCloud Files causes crash
>+        https://bugs.webkit.org/show_bug.cgi?id=193456
>+        <rdar://problem/47275642>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/ios/WebIconUtilities.mm:
>+        (WebKit::fallbackIconForFile):
>+        Bail if we did not get a list of icons.
>+
> 2019-01-07  Dean Jackson  <dino@apple.com>
> 
>         Turn on Pointer Events by default for iOS
>diff --git a/Source/WebKit/Shared/ios/WebIconUtilities.mm b/Source/WebKit/Shared/ios/WebIconUtilities.mm
>index 3670580880c..3af62931fcc 100644
>--- a/Source/WebKit/Shared/ios/WebIconUtilities.mm
>+++ b/Source/WebKit/Shared/ios/WebIconUtilities.mm
>@@ -98,6 +98,9 @@ UIImage* fallbackIconForFile(NSURL *file)
>     ASSERT_ARG(file, [file isFileURL]);
> 
>     UIDocumentInteractionController *interactionController = [UIDocumentInteractionController interactionControllerWithURL:file];
>+    if (!interactionController.icons.count)
>+        return nil;
>+
>     return thumbnailSizedImageForImage(interactionController.icons[0].CGImage);
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193456: 359190 | 360210 | 360376