Attachment 359129 Details for Bug 193428 – Patch

[patch] Patch

bug-193428-20190114225914.patch (text/plain), 5.13 KB, created by cvazac on 2019-01-14 20:59:15 PST

(hide)

Description:

Filename:

MIME Type:

Creator: cvazac

Created: 2019-01-14 20:59:15 PST

Size: 5.13 KB

patch

obsolete

>Subversion Revision: 239973
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d270af322118c720bc47256425e78e33f6f3af6c..1f39a357cf492a1c1f2f3d52d53464062ad017de 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-01-14  Charles Vazac  <cvazac@akamai.com>
>+
>+        Implement PerformanceObserver.supportedEntryTypes
>+        https://bugs.webkit.org/show_bug.cgi?id=193428
>+
>+        PerformanceObserver.supportedEntryTypes should return an array of
>+        entryTypes that can be observed per specification
>+        https://w3c.github.io/performance-timeline/#supportedentrytypes-attribute
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is covered by web-platform-tests
>+        LayoutTests/imported/w3c/web-platform-tests/resource-timing/supported_resource_type.*.html.
>+
>+        * page/PerformanceObserver.cpp:
>+        (WebCore::PerformanceObserver::supportedEntryTypes):
>+        * page/PerformanceObserver.h:
>+        * page/PerformanceObserver.idl:
>+
> 2019-01-14  Simon Fraser  <simon.fraser@apple.com>
> 
>         Only run the node comparison code in FrameSelection::respondToNodeModification() for range selections
>diff --git a/Source/WebCore/page/PerformanceObserver.cpp b/Source/WebCore/page/PerformanceObserver.cpp
>index 4a3c9ffd2c6366340e3d430d5d18f2952bc82528..d622fd1b07a3fec757f1bd73887ca6b049b56e56 100644
>--- a/Source/WebCore/page/PerformanceObserver.cpp
>+++ b/Source/WebCore/page/PerformanceObserver.cpp
>@@ -113,4 +113,15 @@ void PerformanceObserver::deliver()
>     InspectorInstrumentation::didFireObserverCallback(cookie);
> }
> 
>+Vector<String> PerformanceObserver::supportedEntryTypes()
>+{
>+    return Vector<String>({
>+        // FIXME: <https://webkit.org/b/184363> Add support for Navigation Timing Level 2
>+        // "navigation",
>+        "mark",
>+        "measure",
>+        "resource"
>+    });
>+}
>+
> } // namespace WebCore
>diff --git a/Source/WebCore/page/PerformanceObserver.h b/Source/WebCore/page/PerformanceObserver.h
>index 8ab101656d74f57d66a9b53d12963573a313e32d..6ab21f041a152cb80642906d314abb3ef185ef6d 100644
>--- a/Source/WebCore/page/PerformanceObserver.h
>+++ b/Source/WebCore/page/PerformanceObserver.h
>@@ -49,6 +49,8 @@ public:
>         return adoptRef(*new PerformanceObserver(context, WTFMove(callback)));
>     }
> 
>+    static Vector<String> supportedEntryTypes();
>+
>     void disassociate();
> 
>     ExceptionOr<void> observe(Init&&);
>diff --git a/Source/WebCore/page/PerformanceObserver.idl b/Source/WebCore/page/PerformanceObserver.idl
>index f4914be755e21accb400c00ecbb1ca642628ce46..87ede75f62b1c4fb42879d099e4c3162834ab8c1 100644
>--- a/Source/WebCore/page/PerformanceObserver.idl
>+++ b/Source/WebCore/page/PerformanceObserver.idl
>@@ -36,6 +36,7 @@
> ] interface PerformanceObserver {
>     [MayThrowException] void observe(PerformanceObserverInit options);
>     void disconnect();
>+    static readonly attribute FrozenArray<DOMString> supportedEntryTypes;
> };
> 
> dictionary PerformanceObserverInit {
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 02d3c2e4b3d975456db164f4f3fa52b039a17b3e..ab7a45e1139252b34ac7150b502aa23a0fc07f2d 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-01-14  Charles Vazac  <cvazac@akamai.com>
>+
>+        Implement PerformanceObserver.supportedEntryTypes
>+        https://bugs.webkit.org/show_bug.cgi?id=193428
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/resource-timing/supported_resource_type.any-expected.txt:
>+        * web-platform-tests/resource-timing/supported_resource_type.any.worker-expected.txt:
>+
> 2019-01-14  Charles Vazac  <cvazac@akamai.com>
> 
>         Import current Resource-Timing WPTs
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/resource-timing/supported_resource_type.any-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/resource-timing/supported_resource_type.any-expected.txt
>index df46af53fd74b6b04b86738bc2107b5265991ac6..82f33b3df1797edc1cd1e210cdda8bb89ac6bca2 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/resource-timing/supported_resource_type.any-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/resource-timing/supported_resource_type.any-expected.txt
>@@ -1,3 +1,3 @@
> 
>-FAIL supportedEntryTypes contains 'resource'. assert_unreached: supportedEntryTypes is not supported. Reached unreachable code
>+PASS supportedEntryTypes contains 'resource'. 
> 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/resource-timing/supported_resource_type.any.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/resource-timing/supported_resource_type.any.worker-expected.txt
>index df46af53fd74b6b04b86738bc2107b5265991ac6..82f33b3df1797edc1cd1e210cdda8bb89ac6bca2 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/resource-timing/supported_resource_type.any.worker-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/resource-timing/supported_resource_type.any.worker-expected.txt
>@@ -1,3 +1,3 @@
> 
>-FAIL supportedEntryTypes contains 'resource'. assert_unreached: supportedEntryTypes is not supported. Reached unreachable code
>+PASS supportedEntryTypes contains 'resource'. 
>

Actions: View | Formatted Diff | Diff

Attachments on bug 193428: 359123 | 359125 | 359128 | 359129 | 359167 | 359492 | 359518 | 359519