Attachment 359083 Details for Bug 193411 – Patch

[patch] Patch

bug-193411-20190114151053.patch (text/plain), 4.15 KB, created by Alex Christensen on 2019-01-14 15:10:53 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-01-14 15:10:53 PST

Size: 4.15 KB

patch

obsolete

>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 239951)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-14  Alex Christensen  <achristensen@webkit.org>
>+
>+        Bulgarian TLD should not punycode-encode URLs with Bulgarian Cyrillic characters
>+        https://bugs.webkit.org/show_bug.cgi?id=193411
>+        <rdar://problem/47215929>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/cocoa/NSURLExtras.mm:
>+        (WTF::allCharactersAllowedByTLDRules):
>+
> 2019-01-12  Timothy Hatcher  <timothy@apple.com>
> 
>         Have prefers-color-scheme: light always match on macOS versions before Mojave.
>Index: Source/WTF/wtf/cocoa/NSURLExtras.mm
>===================================================================
>--- Source/WTF/wtf/cocoa/NSURLExtras.mm	(revision 239951)
>+++ Source/WTF/wtf/cocoa/NSURLExtras.mm	(working copy)
>@@ -540,6 +540,16 @@ static BOOL allCharactersAllowedByTLDRul
>         return (ch >= 0x0430 && ch <= 0x044f) || ch == 0x0451 || ch == 0x04E9 || ch == 0x04AF || isASCIIDigit(ch) || ch == '-';
>     });
> 
>+    // https://www.icann.org/sites/default/files/packages/lgr/lgr-second-level-bulgarian-30aug16-en.html
>+    static const UChar cyrillicBG[] = {
>+        '.',
>+        0x0431, // CYRILLIC SMALL LETTER BE
>+        0x0433 // CYRILLIC SMALL LETTER GHE
>+    };
>+    CHECK_RULES_IF_SUFFIX_MATCHES(cyrillicBG, [](UChar ch) {
>+        return (ch >= 0x0430 && ch <= 0x044A) || ch == 0x044C || (ch >= 0x044E && ch <= 0x0450) || ch == 0x045D || isASCIIDigit(ch) || ch == '-';
>+    });
>+
>     // Not a known top level domain with special rules.
>     return NO;
> }
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 239927)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-14  Alex Christensen  <achristensen@webkit.org>
>+
>+        Bulgarian TLD should not punycode-encode URLs with Bulgarian Cyrillic characters
>+        https://bugs.webkit.org/show_bug.cgi?id=193411
>+        <rdar://problem/47215929>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/url/user-visible/cyrillic-NFD-expected.txt:
>+        * fast/url/user-visible/cyrillic-NFD.html:
>+
> 2019-01-14  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][BFC] Add basic box-sizing support.
>Index: LayoutTests/fast/url/user-visible/cyrillic-NFD-expected.txt
>===================================================================
>--- LayoutTests/fast/url/user-visible/cyrillic-NFD-expected.txt	(revision 239927)
>+++ LayoutTests/fast/url/user-visible/cyrillic-NFD-expected.txt	(working copy)
>@@ -5,6 +5,11 @@ On success, you will see a series of "PA
> 
> PASS test('http://ÑÐ¿ÐµÑÐ¾Ð´ÐµÐ¶Ð´Ð°.Ð¾Ð½Ð»Ð°Ð¹Ð½/') is 'http://ÑÐ¿ÐµÑÐ¾Ð´ÐµÐ¶Ð´Ð°.Ð¾Ð½Ð»Ð°Ð¹Ð½/'
> PASS test('http://ÑÐ¿ÐµÑÐ¾Ð´ÐµÐ¶Ð´Ð°.Ð¾Ð½Ð»Ð°Ð¸ÌÐ½/') is 'http://ÑÐ¿ÐµÑÐ¾Ð´ÐµÐ¶Ð´Ð°.Ð¾Ð½Ð»Ð°Ð¹Ð½/'
>+PASS test('http://Ð¶1-2.Ð±Ð³/') is 'http://Ð¶1-2.Ð±Ð³/'
>+PASS test('http://Ð¶abc.Ð±Ð³/') is 'http://xn--abc-udd.xn--90ae/'
>+PASS test('http://abc.Ð±Ð³/') is 'http://abc.xn--90ae/'
>+PASS test('http://Ñ.Ð±Ð³/') is 'http://xn--01a.xn--90ae/'
>+PASS test('http://Ñ.Ð±Ð³/') is 'http://xn--21a.xn--90ae/'
> PASS successfullyParsed is true
> 
> TEST COMPLETE
>Index: LayoutTests/fast/url/user-visible/cyrillic-NFD.html
>===================================================================
>--- LayoutTests/fast/url/user-visible/cyrillic-NFD.html	(revision 239927)
>+++ LayoutTests/fast/url/user-visible/cyrillic-NFD.html	(working copy)
>@@ -17,6 +17,11 @@ function test(url)
> 
> shouldBe("test('http://ÑÐ¿ÐµÑÐ¾Ð´ÐµÐ¶Ð´Ð°.Ð¾Ð½Ð»Ð°\u0439Ð½/')", "'http://ÑÐ¿ÐµÑÐ¾Ð´ÐµÐ¶Ð´Ð°.Ð¾Ð½Ð»Ð°Ð¹Ð½/'");
> shouldBe("test('http://ÑÐ¿ÐµÑÐ¾Ð´ÐµÐ¶Ð´Ð°.Ð¾Ð½Ð»Ð°\u0438\u0306Ð½/')", "'http://ÑÐ¿ÐµÑÐ¾Ð´ÐµÐ¶Ð´Ð°.Ð¾Ð½Ð»Ð°Ð¹Ð½/'");
>+shouldBe("test('http://Ð¶1-2.Ð±Ð³/')", "'http://Ð¶1-2.Ð±Ð³/'");
>+shouldBe("test('http://Ð¶abc.Ð±Ð³/')", "'http://xn--abc-udd.xn--90ae/'");
>+shouldBe("test('http://abc.Ð±Ð³/')", "'http://abc.xn--90ae/'");
>+shouldBe("test('http://Ñ.Ð±Ð³/')", "'http://xn--01a.xn--90ae/'");
>+shouldBe("test('http://Ñ.Ð±Ð³/')", "'http://xn--21a.xn--90ae/'");
> 
> </script>
> <script src="../../../resources/js-test-post.js"></script>

Flags:

ap: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193411: 359083