Attachment 359082 Details for Bug 193410 – Cleanup

[patch] Cleanup

bug-193410-20190114144031.patch (text/plain), 11.67 KB, created by Ryosuke Niwa on 2019-01-14 14:40:31 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2019-01-14 14:40:31 PST

Size: 11.67 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 239951)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,38 @@
>+2019-01-14  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        Remove redundant check for alignAttr and hiddenAttr in various isPresentationAttribute overrides
>+        https://bugs.webkit.org/show_bug.cgi?id=193410
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Removed redundant checks for check for alignAttr and hiddenAttr in isPresentationAttribute overrides
>+        in HTMLElement subclasses since HTMLElement::isPresentationAttribute already checks for those attributes.
>+
>+        * html/HTMLDivElement.cpp:
>+        (WebCore::HTMLDivElement::isPresentationAttribute const): Deleted.
>+        * html/HTMLDivElement.h:
>+        * html/HTMLEmbedElement.cpp:
>+        (WebCore::HTMLEmbedElement::isPresentationAttribute const): Deleted.
>+        * html/HTMLEmbedElement.h:
>+        * html/HTMLHRElement.cpp:
>+        (WebCore::HTMLHRElement::isPresentationAttribute const):
>+        * html/HTMLIFrameElement.cpp:
>+        (WebCore::HTMLIFrameElement::isPresentationAttribute const):
>+        * html/HTMLImageElement.cpp:
>+        (WebCore::HTMLImageElement::isPresentationAttribute const):
>+        * html/HTMLInputElement.cpp:
>+        (WebCore::HTMLInputElement::isPresentationAttribute const):
>+        * html/HTMLParagraphElement.cpp:
>+        (WebCore::HTMLParagraphElement::isPresentationAttribute const): Deleted.
>+        * html/HTMLParagraphElement.h:
>+        * html/HTMLTableCaptionElement.cpp:
>+        (WebCore::HTMLTableCaptionElement::isPresentationAttribute const): Deleted.
>+        * html/HTMLTableCaptionElement.h:
>+        * html/HTMLTableElement.cpp:
>+        (WebCore::HTMLTableElement::isPresentationAttribute const):
>+        * html/HTMLTablePartElement.cpp:
>+        (WebCore::HTMLTablePartElement::isPresentationAttribute const):
>+
> 2019-01-14  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r239901, r239909, r239910, r239912,
>Index: Source/WebCore/html/HTMLDivElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLDivElement.cpp	(revision 239943)
>+++ Source/WebCore/html/HTMLDivElement.cpp	(working copy)
>@@ -50,13 +50,6 @@ Ref<HTMLDivElement> HTMLDivElement::crea
>     return adoptRef(*new HTMLDivElement(tagName, document));
> }
> 
>-bool HTMLDivElement::isPresentationAttribute(const QualifiedName& name) const
>-{
>-    if (name == alignAttr)
>-        return true;
>-    return HTMLElement::isPresentationAttribute(name);
>-}
>-
> void HTMLDivElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStyleProperties& style)
> {
>     if (name == alignAttr) {
>Index: Source/WebCore/html/HTMLDivElement.h
>===================================================================
>--- Source/WebCore/html/HTMLDivElement.h	(revision 239943)
>+++ Source/WebCore/html/HTMLDivElement.h	(working copy)
>@@ -36,7 +36,6 @@ protected:
>     HTMLDivElement(const QualifiedName&, Document&);
> 
> private:
>-    bool isPresentationAttribute(const QualifiedName&) const final;
>     void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStyleProperties&) final;
> };
> 
>Index: Source/WebCore/html/HTMLEmbedElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLEmbedElement.cpp	(revision 239943)
>+++ Source/WebCore/html/HTMLEmbedElement.cpp	(working copy)
>@@ -90,13 +90,6 @@ RenderWidget* HTMLEmbedElement::renderWi
>     return findWidgetRenderer(this);
> }
> 
>-bool HTMLEmbedElement::isPresentationAttribute(const QualifiedName& name) const
>-{
>-    if (name == hiddenAttr)
>-        return true;
>-    return HTMLPlugInImageElement::isPresentationAttribute(name);
>-}
>-
> void HTMLEmbedElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStyleProperties& style)
> {
>     if (name == hiddenAttr) {
>Index: Source/WebCore/html/HTMLEmbedElement.h
>===================================================================
>--- Source/WebCore/html/HTMLEmbedElement.h	(revision 239943)
>+++ Source/WebCore/html/HTMLEmbedElement.h	(working copy)
>@@ -36,7 +36,6 @@ private:
>     HTMLEmbedElement(const QualifiedName&, Document&);
> 
>     void parseAttribute(const QualifiedName&, const AtomicString&) final;
>-    bool isPresentationAttribute(const QualifiedName&) const final;
>     void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStyleProperties&) final;
> 
>     bool rendererIsNeeded(const RenderStyle&) final;
>Index: Source/WebCore/html/HTMLHRElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLHRElement.cpp	(revision 239943)
>+++ Source/WebCore/html/HTMLHRElement.cpp	(working copy)
>@@ -54,7 +54,7 @@ Ref<HTMLHRElement> HTMLHRElement::create
> 
> bool HTMLHRElement::isPresentationAttribute(const QualifiedName& name) const
> {
>-    if (name == alignAttr || name == widthAttr || name == colorAttr || name == noshadeAttr || name == sizeAttr)
>+    if (name == widthAttr || name == colorAttr || name == noshadeAttr || name == sizeAttr)
>         return true;
>     return HTMLElement::isPresentationAttribute(name);
> }
>Index: Source/WebCore/html/HTMLIFrameElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLIFrameElement.cpp	(revision 239943)
>+++ Source/WebCore/html/HTMLIFrameElement.cpp	(working copy)
>@@ -62,7 +62,7 @@ DOMTokenList& HTMLIFrameElement::sandbox
> 
> bool HTMLIFrameElement::isPresentationAttribute(const QualifiedName& name) const
> {
>-    if (name == widthAttr || name == heightAttr || name == alignAttr || name == frameborderAttr)
>+    if (name == widthAttr || name == heightAttr || name == frameborderAttr)
>         return true;
>     return HTMLFrameElementBase::isPresentationAttribute(name);
> }
>Index: Source/WebCore/html/HTMLImageElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLImageElement.cpp	(revision 239943)
>+++ Source/WebCore/html/HTMLImageElement.cpp	(working copy)
>@@ -114,7 +114,7 @@ Ref<HTMLImageElement> HTMLImageElement::
> 
> bool HTMLImageElement::isPresentationAttribute(const QualifiedName& name) const
> {
>-    if (name == widthAttr || name == heightAttr || name == borderAttr || name == vspaceAttr || name == hspaceAttr || name == alignAttr || name == valignAttr)
>+    if (name == widthAttr || name == heightAttr || name == borderAttr || name == vspaceAttr || name == hspaceAttr || name == valignAttr)
>         return true;
>     return HTMLElement::isPresentationAttribute(name);
> }
>Index: Source/WebCore/html/HTMLInputElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLInputElement.cpp	(revision 239943)
>+++ Source/WebCore/html/HTMLInputElement.cpp	(working copy)
>@@ -645,7 +645,7 @@ void HTMLInputElement::accessKeyAction(b
> 
> bool HTMLInputElement::isPresentationAttribute(const QualifiedName& name) const
> {
>-    if (name == vspaceAttr || name == hspaceAttr || name == alignAttr || name == widthAttr || name == heightAttr || (name == borderAttr && isImageButton()))
>+    if (name == vspaceAttr || name == hspaceAttr || name == widthAttr || name == heightAttr || (name == borderAttr && isImageButton()))
>         return true;
>     return HTMLTextFormControlElement::isPresentationAttribute(name);
> }
>Index: Source/WebCore/html/HTMLParagraphElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLParagraphElement.cpp	(revision 239943)
>+++ Source/WebCore/html/HTMLParagraphElement.cpp	(working copy)
>@@ -51,13 +51,6 @@ Ref<HTMLParagraphElement> HTMLParagraphE
>     return adoptRef(*new HTMLParagraphElement(tagName, document));
> }
> 
>-bool HTMLParagraphElement::isPresentationAttribute(const QualifiedName& name) const
>-{
>-    if (name == alignAttr)
>-        return true;
>-    return HTMLElement::isPresentationAttribute(name);
>-}
>-
> void HTMLParagraphElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStyleProperties& style)
> {
>     if (name == alignAttr) {
>Index: Source/WebCore/html/HTMLParagraphElement.h
>===================================================================
>--- Source/WebCore/html/HTMLParagraphElement.h	(revision 239943)
>+++ Source/WebCore/html/HTMLParagraphElement.h	(working copy)
>@@ -35,7 +35,6 @@ public:
> private:
>     HTMLParagraphElement(const QualifiedName&, Document&);
> 
>-    bool isPresentationAttribute(const QualifiedName&) const final;
>     void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStyleProperties&) final;
> };
> 
>Index: Source/WebCore/html/HTMLTableCaptionElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLTableCaptionElement.cpp	(revision 239943)
>+++ Source/WebCore/html/HTMLTableCaptionElement.cpp	(working copy)
>@@ -46,13 +46,6 @@ Ref<HTMLTableCaptionElement> HTMLTableCa
>     return adoptRef(*new HTMLTableCaptionElement(tagName, document));
> }
> 
>-bool HTMLTableCaptionElement::isPresentationAttribute(const QualifiedName& name) const
>-{
>-    if (name == alignAttr)
>-        return true;
>-    return HTMLElement::isPresentationAttribute(name);
>-}
>-
> void HTMLTableCaptionElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStyleProperties& style)
> {
>     if (name == alignAttr) {
>Index: Source/WebCore/html/HTMLTableCaptionElement.h
>===================================================================
>--- Source/WebCore/html/HTMLTableCaptionElement.h	(revision 239943)
>+++ Source/WebCore/html/HTMLTableCaptionElement.h	(working copy)
>@@ -37,7 +37,6 @@ public:
> private:
>     HTMLTableCaptionElement(const QualifiedName&, Document&);
> 
>-    bool isPresentationAttribute(const QualifiedName&) const final;
>     void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStyleProperties&) final;
> };
> 
>Index: Source/WebCore/html/HTMLTableElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLTableElement.cpp	(revision 239943)
>+++ Source/WebCore/html/HTMLTableElement.cpp	(working copy)
>@@ -363,7 +363,7 @@ void HTMLTableElement::collectStyleForPr
> 
> bool HTMLTableElement::isPresentationAttribute(const QualifiedName& name) const
> {
>-    if (name == widthAttr || name == heightAttr || name == bgcolorAttr || name == backgroundAttr || name == valignAttr || name == vspaceAttr || name == hspaceAttr || name == alignAttr || name == cellspacingAttr || name == borderAttr || name == bordercolorAttr || name == frameAttr || name == rulesAttr)
>+    if (name == widthAttr || name == heightAttr || name == bgcolorAttr || name == backgroundAttr || name == valignAttr || name == vspaceAttr || name == hspaceAttr || name == cellspacingAttr || name == borderAttr || name == bordercolorAttr || name == frameAttr || name == rulesAttr)
>         return true;
>     return HTMLElement::isPresentationAttribute(name);
> }
>Index: Source/WebCore/html/HTMLTablePartElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLTablePartElement.cpp	(revision 239943)
>+++ Source/WebCore/html/HTMLTablePartElement.cpp	(working copy)
>@@ -43,7 +43,7 @@ using namespace HTMLNames;
> 
> bool HTMLTablePartElement::isPresentationAttribute(const QualifiedName& name) const
> {
>-    if (name == bgcolorAttr || name == backgroundAttr || name == valignAttr || name == alignAttr || name == heightAttr)
>+    if (name == bgcolorAttr || name == backgroundAttr || name == valignAttr || name == heightAttr)
>         return true;
>     return HTMLElement::isPresentationAttribute(name);
> }

Flags:

simon.fraser: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193410: 359081 | 359082