WebKit Bugzilla
Attachment 359078 Details for
Bug 193409
: Web Inspector: Generate the DOMDebugger domain for Augmenting Agents (ObjC protocol)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
[PATCH] Proposed Fix
domdebugger-1.patch (text/plain), 1.57 KB, created by
Joseph Pecoraro
on 2019-01-14 14:28:22 PST
(
hide
)
Description:
[PATCH] Proposed Fix
Filename:
MIME Type:
Creator:
Joseph Pecoraro
Created:
2019-01-14 14:28:22 PST
Size:
1.57 KB
patch
obsolete
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 92e1266a38b..0857fa66285 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,15 @@ >+2019-01-14 Joseph Pecoraro <pecoraro@apple.com> >+ >+ Web Inspector: Generate the DOMDebugger domain for Augmenting Agents (ObjC protocol) >+ https://bugs.webkit.org/show_bug.cgi?id=193409 >+ <rdar://problem/44349411> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * inspector/scripts/codegen/objc_generator.py: >+ (ObjCGenerator): >+ Generate DOMDebugger domain ObjC interfaces. >+ > 2019-01-08 Joseph Pecoraro <pecoraro@apple.com> > > ASSERT when paused in debugger and console evaluation causes exception >diff --git a/Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py b/Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py >index 3508503b6ba..682fc7f23ee 100755 >--- a/Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py >+++ b/Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py >@@ -122,7 +122,7 @@ class ObjCGenerator(Generator): > > # Generate ObjC types, command handlers, and event dispatchers for a subset of domains. > >- DOMAINS_TO_GENERATE = ['CSS', 'DOM', 'DOMStorage', 'Network', 'Security', 'Page', 'Automation', 'GenericTypes'] >+ DOMAINS_TO_GENERATE = ['CSS', 'DOM', 'DOMDebugger', 'DOMStorage', 'Network', 'Security', 'Page', 'Automation', 'GenericTypes'] > > def should_generate_types_for_domain(self, domain): > if not len(self.type_declarations_for_domain(domain)):
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 193409
: 359078