Attachment 359074 Details for Bug 193362 – Patch

[patch] Patch

bug-193362-20190114132046.patch (text/plain), 1.45 KB, created by Jonathan Bedard on 2019-01-14 13:20:46 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-01-14 13:20:46 PST

Size: 1.45 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 239936)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-01-14  Jonathan Bedard  <jbedard@apple.com>
>+
>+        webkitpy: Support alternate simctl device list output (Follow-up fix)
>+        https://bugs.webkit.org/show_bug.cgi?id=193362
>+        <rdar://problem/47122965>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/xcode/simulated_device.py:
>+        (SimulatedDeviceManager.populate_available_devices):
>+
> 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] Expose SPI to access the current sentence boundary and selection state
>Index: Tools/Scripts/webkitpy/xcode/simulated_device.py
>===================================================================
>--- Tools/Scripts/webkitpy/xcode/simulated_device.py	(revision 239929)
>+++ Tools/Scripts/webkitpy/xcode/simulated_device.py	(working copy)
>@@ -139,7 +139,7 @@ class SimulatedDeviceManager(object):
>                         devices = devices_for_runtime['devices']
>                         break
>             else:
>-                devices = simctl_json['devices'][runtime.name]
>+                devices = simctl_json['devices'].get(runtime.name, None) or simctl_json['devices'].get(runtime.identifier, [])
> 
>             for device_json in devices:
>                 device = SimulatedDeviceManager._create_device_with_runtime(host, runtime, device_json)

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 193362: 358939 | 358945 | 359074