Attachment 359043 Details for Bug 193400 – Patch

[patch] Patch

bug-193400-20190114093814.patch (text/plain), 2.12 KB, created by youenn fablet on 2019-01-14 09:38:15 PST

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-01-14 09:38:15 PST

Size: 2.12 KB

patch

obsolete

>Subversion Revision: 239787
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index e3cec7c5ed64bb1d528944e374485abdd73ccf8b..3fe614eaf9c3bd1705a4a46d4ee28922d4d4d2b7 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-11  Youenn Fablet  <youenn@apple.com>
>+
>+        CacheStorage::Engine::from should query the engine map with the default private session ID in case of ephemeral sessions
>+        https://bugs.webkit.org/show_bug.cgi?id=193400
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We should query the engine map with the 'unique' ephemeral session ID.
>+        This will prevent unnecessary IPC messages to query cache storage parameters to UIProcess.
>+
>+        * NetworkProcess/cache/CacheStorageEngine.cpp:
>+        (WebKit::CacheStorage::Engine::from):
>+        * WebKit.xcodeproj/project.pbxproj:
>+
> 2019-01-10  Youenn Fablet  <youenn@apple.com>
> 
>         Add a new SPI to request for cache storage quota increase
>diff --git a/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp b/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp
>index 34122bb61420a5e447b35712fbdf7c40fc7dfb4c..b6817a06ba998e42f9535135e97970dd795027d1 100644
>--- a/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp
>+++ b/Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp
>@@ -75,14 +75,14 @@ Engine::~Engine()
> 
> void Engine::from(NetworkProcess& networkProcess, PAL::SessionID sessionID, Function<void(Engine&)>&& callback)
> {
>+    if (sessionID.isEphemeral())
>+        sessionID = PAL::SessionID::legacyPrivateSessionID();
>+
>     if (auto* engine = networkProcess.findCacheEngine(sessionID)) {
>         callback(*engine);
>         return;
>     }
> 
>-    if (sessionID.isEphemeral())
>-        sessionID = PAL::SessionID::legacyPrivateSessionID();
>-
>     networkProcess.cacheStorageParameters(sessionID, [networkProcess = makeRef(networkProcess), sessionID, callback = WTFMove(callback)] (auto&& rootPath, auto quota) mutable {
>         callback(networkProcess->ensureCacheEngine(sessionID, [&] {
>             return adoptRef(*new Engine { sessionID, networkProcess.get(), String { rootPath }, quota });

Actions: View | Formatted Diff | Diff

Attachments on bug 193400: 359043 | 359161