Attachment 359034 Details for Bug 193397 – Patch

[patch] Patch

bug-193397-20190114115007.patch (text/plain), 2.96 KB, created by Thibault Saunier on 2019-01-14 06:50:09 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Thibault Saunier

Created: 2019-01-14 06:50:09 PST

Size: 2.96 KB

patch

obsolete

>Subversion Revision: 239920
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c6c9f61c7de47f2d1af42a3c0998a25ccbdc7503..704cbc99d3f2b7d9b9e58347f654f41fe35e5ca3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-01-14  Thibault Saunier  <tsaunier@igalia.com>
>+
>+        [GStreamer][WebRTC] Override DeviceType() in RealtimeMediaSource implementations
>+        https://bugs.webkit.org/show_bug.cgi?id=193397
>+
>+        This was necessary but wasn't done.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No test required as this fixes a regression in all WebRTC tests when built in debug mode.
>+
>+        * platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h:
>+        * platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
>+
> 2019-01-14  Karl Leplat  <karl.leplat_ext@softathome.com>
> 
>         [GTK][WPE] Graphic issue with invalidations on composited layers with subpixel positions
>diff --git a/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h b/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h
>index 5229a251cc59428318d60cba19de1e8c94d094ba..36087c089875f128bf7d658fe85759762d3481c0 100644
>--- a/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h
>+++ b/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h
>@@ -22,6 +22,7 @@
> #pragma once
> 
> #if ENABLE(MEDIA_STREAM) && USE(LIBWEBRTC) && USE(GSTREAMER)
>+#include "CaptureDevice.h"
> #include "GStreamerAudioCapturer.h"
> #include "GStreamerCaptureDevice.h"
> #include "RealtimeMediaSource.h"
>@@ -45,6 +46,7 @@ protected:
>     virtual ~GStreamerAudioCaptureSource();
>     void startProducingData() override;
>     void stopProducingData() override;
>+    CaptureDevice::DeviceType deviceType() const override { return CaptureDevice::DeviceType::Microphone; }
> 
>     mutable Optional<RealtimeMediaSourceCapabilities> m_capabilities;
>     mutable Optional<RealtimeMediaSourceSettings> m_currentSettings;
>diff --git a/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h b/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h
>index cb5e651cd37b8f630184f2e861e71b8e8f3d3991..4681d118dd966d3a83d0a23fd82fccd272f9d433 100644
>--- a/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h
>+++ b/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h
>@@ -22,6 +22,7 @@
> #pragma once
> 
> #if ENABLE(MEDIA_STREAM) && USE(LIBWEBRTC) && USE(GSTREAMER)
>+#include "CaptureDevice.h"
> #include "GStreamerVideoCapturer.h"
> #include "RealtimeVideoSource.h"
> 
>@@ -52,6 +53,7 @@ protected:
> 
>     mutable Optional<RealtimeMediaSourceCapabilities> m_capabilities;
>     mutable Optional<RealtimeMediaSourceSettings> m_currentSettings;
>+    CaptureDevice::DeviceType deviceType() const override { return CaptureDevice::DeviceType::Camera; }
> 
> private:
>     static GstFlowReturn newSampleCallback(GstElement*, GStreamerVideoCaptureSource*);

Actions: View | Formatted Diff | Diff

Attachments on bug 193397: 359034